From: Chris PeBenito <pebenito@ieee.org>
To: Russell Coker <russell@coker.com.au>, selinux-refpolicy@vger.kernel.org
Subject: Re: append_lnk_files_pattern
Date: Mon, 2 Oct 2023 08:40:50 -0400 [thread overview]
Message-ID: <9629e26a-381b-5482-1493-ac3387616507@ieee.org> (raw)
In-Reply-To: <4932293.0VBMTVartN@cupcakke>
On 9/30/2023 7:55 AM, Russell Coker wrote:
> Why do we have the pattern append_lnk_files_pattern? It's not used anywhere
> in refpolicy along with write_lnk_files_pattern. The sesearch command shows
> only the following uses of append permission for lnk_file.
More than likely it's simply a copy-paste when I first generated the macros.
> # sesearch -A -c lnk_file -p append
> allow files_unconfined_type file_type:lnk_file { append create execmod execute
> getattr ioctl link lock map mounton open quotaon read relabelfrom relabelto
> rename setattr unlink watch write };
> allow filesystem_unconfined_type filesystem_type:lnk_file { append create
> execmod execute getattr ioctl link lock map mounton open quotaon read
> relabelfrom relabelto rename setattr unlink watch write };
> allow kern_unconfined proc_type:lnk_file { append create execmod execute
> getattr ioctl link lock map mounton open quotaon read relabelfrom relabelto
> rename setattr unlink watch write };
> allow kern_unconfined unlabeled_t:lnk_file { append create execmod execute
> getattr ioctl link lock map mounton open quotaon read relabelfrom relabelto
> rename setattr unlink watch write };
>
> I guess that the kern_unconfined stuff is related to the magic symlinks in /
> proc/PID directories. Is there any other way where a symlink can be appended?
>
> Does it make sense to have the append macros and the write macros with append
> permission included?
The way I see it (and how the various perm macros are designed), if a
rule has write, then append is also implied. Append may not make sense
for lnk_file, but I don't see a downside to having it.
--
Chris PeBenito
prev parent reply other threads:[~2023-10-02 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 11:55 append_lnk_files_pattern Russell Coker
2023-10-02 12:40 ` Chris PeBenito [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9629e26a-381b-5482-1493-ac3387616507@ieee.org \
--to=pebenito@ieee.org \
--cc=russell@coker.com.au \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).