From: David Miller <davem@davemloft.net>
To: paul@paul-moore.com
Cc: selinux@vger.kernel.org, netdev@vger.kernel.org, jiri@mellanox.com
Subject: Re: [PATCH] selinux: add support for RTM_NEWCHAIN, RTM_DELCHAIN, and RTM_GETCHAIN
Date: Wed, 28 Nov 2018 11:34:59 -0800 (PST) [thread overview]
Message-ID: <20181128.113459.2243338883107175423.davem@davemloft.net> (raw)
In-Reply-To: <CAHC9VhSbqnN-brs0ssbCeAcUWGhUyRYR=FBYB1yB9uuR7_UeOQ@mail.gmail.com>
From: Paul Moore <paul@paul-moore.com>
Date: Wed, 28 Nov 2018 13:47:25 -0500
> On Wed, Nov 28, 2018 at 1:44 PM Paul Moore <paul@paul-moore.com> wrote:
>> Commit 32a4f5ecd738 ("net: sched: introduce chain object to uapi")
>> added new RTM_* definitions without properly updating SELinux, this
>> patch adds the necessary SELinux support.
>>
>> While there was a BUILD_BUG_ON() in the SELinux code to protect from
>> exactly this case, it was bypassed in the broken commit. In order to
>> hopefully prevent this from happening in the future, add additional
>> comments which provide some instructions on how to resolve the
>> BUILD_BUG_ON() failures.
>>
>> Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi")
>> Cc: <stable@vger.kernel.org> # 4.19
>> Signed-off-by: Paul Moore <paul@paul-moore.com>
>> ---
>> security/selinux/nlmsgtab.c | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> I'm building a test kernel right now, assuming all goes well I'm going
> to send this up to Linus for v4.20.
Acked-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2018-11-28 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 18:44 [PATCH] selinux: add support for RTM_NEWCHAIN, RTM_DELCHAIN, and RTM_GETCHAIN Paul Moore
2018-11-28 18:47 ` Paul Moore
2018-11-28 19:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128.113459.2243338883107175423.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).