selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bill.c.roberts@gmail.com
To: plautrba@redhat.com
Cc: bigon@debian.org, bill.c.roberts@gmail.com,
	selinux@vger.kernel.org, stephen.smalley.work@gmail.com,
	William Roberts <william.c.roberts@intel.com>
Subject: [PATCH] README: start a section for documenting CFLAGS
Date: Tue,  2 Jun 2020 13:55:07 -0500	[thread overview]
Message-ID: <20200602185507.3784-1-william.c.roberts@intel.com> (raw)
In-Reply-To: <20200601093453.GB30453@workstation>

From: William Roberts <william.c.roberts@intel.com>

Start a section in the README for documenting that custom CFLAGS yeilds
CUSTOM results and that your mileage may vary. The first CFLAG to
document that you likely want to include is -fsemantic-interposition.

Signed-off-by: William Roberts <william.c.roberts@intel.com>
---
 README.md | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/README.md b/README.md
index 9d64f0b5cf90..f37a9f91f51e 100644
--- a/README.md
+++ b/README.md
@@ -120,6 +120,17 @@ lacks library functions or other dependencies relied upon by your
 distribution.  If it breaks, you get to keep both pieces.
 
 
+## Setting CFLAGS
+
+Setting CFLAGS during the make process will cause the omission of many default CFLAGS. While the project strives
+to provide a sane set of default CFLAGS, custom CFLAGS could break the build, or have other undesired changes
+on the build output. Thus, be very careful when setting CFLAGS. CFLAGS that we encourage to be set when
+overriding CFLAGS are:
+
+- -fsemantic-interposition for gcc or compilers that do not do this. clang does this by default. clang-10 and up
+   will support passing this flag, but ignore it. Previous clang versions fail.
+
+
 macOS
 -----
 
-- 
2.17.1


  reply	other threads:[~2020-06-02 18:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-23 10:56 CFLAGS overridden by distribution build system Laurent Bigonville
2020-05-23 15:59 ` William Roberts
2020-05-29 13:31   ` Stephen Smalley
2020-05-29 16:04     ` William Roberts
2020-05-29 16:40       ` Stephen Smalley
2020-05-29 17:15         ` William Roberts
2020-05-29 18:18           ` Stephen Smalley
2020-05-29 20:59             ` William Roberts
2020-06-01  9:34               ` Petr Lautrbach
2020-06-02 18:55                 ` bill.c.roberts [this message]
2020-06-04 19:03                   ` [PATCH] README: start a section for documenting CFLAGS Stephen Smalley
2020-06-08 15:37                     ` [PATCH v2] " bill.c.roberts
2020-06-08 16:21                       ` Stephen Smalley
2020-06-08 22:34                         ` William Roberts
2020-06-08 22:38                         ` [PATCH v3] " bill.c.roberts
2020-06-09 11:57                           ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200602185507.3784-1-william.c.roberts@intel.com \
    --to=bill.c.roberts@gmail.com \
    --cc=bigon@debian.org \
    --cc=plautrba@redhat.com \
    --cc=selinux@vger.kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    --cc=william.c.roberts@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).