From: Stephen Smalley <sds@tycho.nsa.gov>
To: "Petr Lautrbach" <plautrba@redhat.com>,
"Christian Göttsche" <cgzones@googlemail.com>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH] libselinux: drop error return from is_selinux_enabled.3
Date: Fri, 7 Feb 2020 12:51:59 -0500 [thread overview]
Message-ID: <53df5cb3-798c-66da-604b-94e7e48c5803@tycho.nsa.gov> (raw)
In-Reply-To: <pjd36bm4dat.fsf@redhat.com>
On 2/7/20 10:39 AM, Petr Lautrbach wrote:
>
> Christian Göttsche <cgzones@googlemail.com> writes:
>
>> is_selinux_enabled() does never return -1, do not say so in the manpage.
Just as a historical footnote: it used to be possible that it would
return -1 prior to commit e3cab998b48ab293a9962faf9779d70ca339c65d circa
release 20120216.
>>
>> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
>> ---
>> libselinux/man/man3/is_selinux_enabled.3 | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/libselinux/man/man3/is_selinux_enabled.3 b/libselinux/man/man3/is_selinux_enabled.3
>> index df62c225..a887b48c 100644
>> --- a/libselinux/man/man3/is_selinux_enabled.3
>> +++ b/libselinux/man/man3/is_selinux_enabled.3
>> @@ -15,7 +15,6 @@ is_selinux_mls_enabled \- check whether SELinux is enabled for (Multi Level Secu
>> .SH "DESCRIPTION"
>> .BR is_selinux_enabled ()
>> returns 1 if SELinux is running or 0 if it is not.
>> -On error, \-1 is returned.
>>
>> .BR is_selinux_mls_enabled ()
>> returns 1 if SELinux is capable of running in MLS mode or 0 if it is not. To
>
>
> There's also
>
> libselinux/include/selinux/selinux.h:
>
> /* Return 1 if we are running on a SELinux kernel, or 0 if not or -1 if we get an error. */
> extern int is_selinux_enabled(void);
>
>
> Would you mind to update this as well?
>
> Thanks,
>
> Petr
>
next prev parent reply other threads:[~2020-02-07 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 14:37 [PATCH] libselinux: drop error return from is_selinux_enabled.3 Christian Göttsche
2020-02-07 15:39 ` Petr Lautrbach
2020-02-07 17:51 ` Stephen Smalley [this message]
2020-02-11 19:12 ` Christian Göttsche
2020-02-11 19:52 ` Stephen Smalley
2020-02-14 18:47 ` [PATCH] libselinux: drop error return from is_selinux_enabled documentation Christian Göttsche
2020-02-14 19:42 ` Stephen Smalley
2020-02-18 15:41 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53df5cb3-798c-66da-604b-94e7e48c5803@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=cgzones@googlemail.com \
--cc=plautrba@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).