From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: James Carter <jwcart2@gmail.com>
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] libsepol: Improve writing CIL category rules
Date: Wed, 27 May 2020 15:23:14 -0400 [thread overview]
Message-ID: <CAEjxPJ5BHwcAW8hRu3e8EP-VoykBSQiJTcw73EKTAFMRu7d6HA@mail.gmail.com> (raw)
In-Reply-To: <CAP+JOzTBqkDgqizyLodJk09-Ru3Kr54Wp=gOO-s_K+ZVX=cu+Q@mail.gmail.com>
On Wed, May 27, 2020 at 1:20 PM James Carter <jwcart2@gmail.com> wrote:
>
> On Wed, May 27, 2020 at 12:44 PM Stephen Smalley
> <stephen.smalley.work@gmail.com> wrote:
> >
> > On Fri, May 22, 2020 at 10:58 AM James Carter <jwcart2@gmail.com> wrote:
> > >
> > > Improves writing of CIL category rules when converting MLS kernel
> > > policy to CIL. No changes to functionality, but eliminate useless
> > > checks for category aliases when using the p_cat_val_to_name array,
> > > find the actual number of aliases before allocating memory, and
> > > skip the category alias rules if there are no aliases.
> > >
> > > Signed-off-by: James Carter <jwcart2@gmail.com>
> >
> > This series looks fine to me but do you have a test case that exercises it?
>
> See attached.
Ok we should likely try to move some of these out of tree tests into
the set of tests exercised by
make test in libsepol or checkpolicy or secilc and thereby get them
regression tested by travis-ci.
Regardless, for this series,
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
next prev parent reply other threads:[~2020-05-27 19:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 14:55 [PATCH v2 1/3] libsepol: Write CIL default MLS rules on separate lines James Carter
2020-05-22 14:55 ` [PATCH v2 2/3] libsepol: Improve writing CIL sensitivity rules James Carter
2020-05-22 14:55 ` [PATCH v2 3/3] libsepol: Improve writing CIL category rules James Carter
2020-05-27 16:44 ` Stephen Smalley
2020-05-27 17:20 ` James Carter
2020-05-27 19:23 ` Stephen Smalley [this message]
2020-05-29 12:58 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEjxPJ5BHwcAW8hRu3e8EP-VoykBSQiJTcw73EKTAFMRu7d6HA@mail.gmail.com \
--to=stephen.smalley.work@gmail.com \
--cc=jwcart2@gmail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).