From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: Petr Lautrbach <plautrba@redhat.com>
Cc: SElinux list <selinux@vger.kernel.org>,
Topi Miettinen <toiwoton@gmail.com>
Subject: Re: [PATCH v3] secilc/docs: fix use of TMPDIR
Date: Fri, 29 May 2020 09:03:44 -0400 [thread overview]
Message-ID: <CAEjxPJ6EQmzHqXWO02GzCwf-uLG1zePkkhgboAknqwxdxR04hQ@mail.gmail.com> (raw)
In-Reply-To: <20200515133540.GD255621@workstation>
On Fri, May 15, 2020 at 9:36 AM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> On Fri, May 15, 2020 at 02:41:11PM +0300, Topi Miettinen wrote:
> > Environment variable TMPDIR may be already set for the user building
> > and this could be equal to $XDG_RUNTIME_DIR or /tmp which are existing
> > directories. Then when running 'make clean', there are unintended side
> > effects:
> >
> > rm -rf /run/user/1000
> > rm: cannot remove '/run/user/1000/dconf/user': Permission denied
> > rm: cannot remove '/run/user/1000/systemd': Permission denied
> > rm: cannot remove '/run/user/1000/gnupg': Permission denied
> > rm: cannot remove '/run/user/1000/dbus-1': Is a directory
> > rm: cannot remove '/run/user/1000/inaccessible': Permission denied
> > make[1]: *** [Makefile:68: clean] Error 1
> >
> > Fix by always setting the variable.
> >
> > Signed-off-by: Topi Miettinen <toiwoton@gmail.com>
> > Suggested-by: Petr Lautrbach <plautrba@redhat.com>
>
> Acked-by: Petr Lautrbach <plautrba@redhat.com>
Should I merge this or do you have it?
next prev parent reply other threads:[~2020-05-29 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 11:41 [PATCH v3] secilc/docs: fix use of TMPDIR Topi Miettinen
2020-05-15 13:35 ` Petr Lautrbach
2020-05-29 13:03 ` Stephen Smalley [this message]
2020-06-01 8:43 ` Petr Lautrbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEjxPJ6EQmzHqXWO02GzCwf-uLG1zePkkhgboAknqwxdxR04hQ@mail.gmail.com \
--to=stephen.smalley.work@gmail.com \
--cc=plautrba@redhat.com \
--cc=selinux@vger.kernel.org \
--cc=toiwoton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).