From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: Topi Miettinen <toiwoton@gmail.com>, linux-audit@redhat.com
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH v2] semanage: handle getprotobyname() failure case
Date: Mon, 22 Jun 2020 08:22:48 -0400 [thread overview]
Message-ID: <CAEjxPJ6eevd1JOQN_8yC1SyQWoqPwkBvGJDu=ju+Dpku666KhQ@mail.gmail.com> (raw)
In-Reply-To: <CAEjxPJ50YNJViUUA=7jaLwzPDMJUE0xzegAes4YF=TwpAo88YQ@mail.gmail.com>
On Mon, Jun 8, 2020 at 12:18 PM Stephen Smalley
<stephen.smalley.work@gmail.com> wrote:
>
> On Fri, Jun 5, 2020 at 4:24 AM Topi Miettinen <toiwoton@gmail.com> wrote:
> >
> > At least on Debian, /etc/protocols, which is used by
> > socket.getprotobyname() to resolve protocols to names, does not
> > contain an entry for "ipv4". In that case, set the protocol number
> > used by audit logs for "ipv4" to a fixed value. To ensure audit log
> > compatibility, let's use the same numeric value as Fedora: 4, which is
> > actually understood by kernel as IP over IP.
> >
> > Signed-off-by: Topi Miettinen <toiwoton@gmail.com>
>
> This looks fine to me but adding linux-audit mailing list to see if
> they have any concerns. It appears to make no change to the audit
> messages on Fedora.
Seeing no objections from linux-audit,
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
next prev parent reply other threads:[~2020-06-22 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 8:19 [PATCH v2] semanage: handle getprotobyname() failure case Topi Miettinen
2020-06-08 16:18 ` Stephen Smalley
2020-06-22 12:22 ` Stephen Smalley [this message]
2020-06-25 17:30 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEjxPJ6eevd1JOQN_8yC1SyQWoqPwkBvGJDu=ju+Dpku666KhQ@mail.gmail.com' \
--to=stephen.smalley.work@gmail.com \
--cc=linux-audit@redhat.com \
--cc=selinux@vger.kernel.org \
--cc=toiwoton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).