From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: William Roberts <bill.c.roberts@gmail.com>,
SElinux list <selinux@vger.kernel.org>,
Petr Lautrbach <plautrba@redhat.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Ulrich Drepper <drepper@redhat.com>,
Ondrej Mosnacek <omosnace@redhat.com>
Subject: Re: [PATCH v3 3/4] Makefile: add linker script to minimize exports
Date: Fri, 28 Feb 2020 14:05:53 -0500 [thread overview]
Message-ID: <CAEjxPJ7tt7T1NaYcG6B+k9smtcjrM0WXQXDXjnx5A=FNPLPt4w@mail.gmail.com> (raw)
In-Reply-To: <CAFftDdpeP39qvXNTe06EWkc3Kp_TMu5bGOf8WN6Q-k2Cehn_3w@mail.gmail.com>
On Fri, Feb 28, 2020 at 1:43 PM William Roberts
<bill.c.roberts@gmail.com> wrote:
>
> On Fri, Feb 28, 2020 at 12:35 PM Stephen Smalley
> <stephen.smalley.work@gmail.com> wrote:
> >
> > On Fri, Feb 28, 2020 at 10:49 AM <bill.c.roberts@gmail.com> wrote:
> > > diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile
> > > index c76110fbc650..f74dbeb983dd 100644
> > > --- a/libselinux/src/Makefile
> > > +++ b/libselinux/src/Makefile
> > > @@ -90,7 +90,7 @@ CFLAGS ?= -O -Wall -W -Wundef -Wformat-y2k -Wformat-security -Winit-self -Wmissi
> > > -Werror -Wno-aggregate-return -Wno-redundant-decls \
> > > $(EXTRA_CFLAGS)
> > >
> > > -LD_SONAME_FLAGS=-soname,$(LIBSO),-z,defs,-z,relro
> > > +LD_SONAME_FLAGS=-soname,$(LIBSO),-z,defs,-z,relro-Wl,--version-script=libselinux.map
> >
> > /usr/bin/ld: warning: -z relro-Wl ignored
> > I guess you meant relro,-Wl but you don't want that either. -Wl has
> > to precede all the flags and it is already pre-pended later in the
> > Makefile.
>
> Grumble, did I ever say I *hate* Makefiles! v4 coming, im going to
> hold them so I can coalesce any other feedback
> into v4.
(restored cc; I accidentally only replied to you)
next prev parent reply other threads:[~2020-02-28 19:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 23:01 libselinux: drop dso.h bill.c.roberts
2020-02-27 23:01 ` [PATCH 1/3] dso: drop hidden_proto and hidden_def bill.c.roberts
2020-02-27 23:01 ` [PATCH 2/3] Makefile: add -fno-semantic-interposition bill.c.roberts
2020-02-28 13:51 ` Stephen Smalley
2020-02-28 13:59 ` William Roberts
2020-03-01 20:32 ` Nicolas Iooss
2020-03-02 16:41 ` [V4] libselinux: drop dso.h bill.c.roberts
2020-03-02 16:41 ` [PATCH v4 1/4] dso: drop hidden_proto and hidden_def bill.c.roberts
2020-03-02 16:41 ` [PATCH v4 2/4] Makefile: add -fno-semantic-interposition bill.c.roberts
2020-03-02 16:41 ` [PATCH v4 3/4] Makefile: add linker script to minimize exports bill.c.roberts
2020-03-02 16:41 ` [PATCH v4 4/4] libselinux: drop symbols from map bill.c.roberts
2020-03-03 18:58 ` [V4] libselinux: drop dso.h Stephen Smalley
2020-03-04 12:26 ` Ondrej Mosnacek
2020-03-04 13:48 ` William Roberts
2020-03-04 13:15 ` Petr Lautrbach
2020-03-05 12:42 ` Petr Lautrbach
2020-03-05 16:12 ` William Roberts
2020-03-05 19:09 ` William Roberts
2020-03-11 18:14 ` Stephen Smalley
2020-03-12 14:05 ` William Roberts
2020-02-27 23:01 ` [PATCH 3/3] Makefile: add linker script to minimize exports bill.c.roberts
2020-02-28 13:36 ` Stephen Smalley
2020-02-28 13:38 ` William Roberts
2020-02-28 14:05 ` [V2] libselinux: drop dso.h bill.c.roberts
2020-02-28 14:05 ` [PATCH v2 1/4] dso: drop hidden_proto and hidden_def bill.c.roberts
2020-02-28 14:05 ` [PATCH v2 2/4] Makefile: add -fno-semantic-interposition bill.c.roberts
2020-02-28 14:05 ` [PATCH v2 3/4] Makefile: add linker script to minimize exports bill.c.roberts
2020-02-28 14:05 ` [PATCH v2 4/4] libselinux: drop symbols from map bill.c.roberts
2020-02-28 15:39 ` Stephen Smalley
2020-02-28 15:40 ` William Roberts
2020-02-28 15:48 ` [V3] libselinux: drop dso.h bill.c.roberts
2020-02-28 15:48 ` [PATCH v3 1/4] dso: drop hidden_proto and hidden_def bill.c.roberts
2020-02-28 15:48 ` [PATCH v3 2/4] Makefile: add -fno-semantic-interposition bill.c.roberts
2020-02-28 15:48 ` [PATCH v3 3/4] Makefile: add linker script to minimize exports bill.c.roberts
[not found] ` <CAEjxPJ7CuMf5QeW_jjEonRN=kfcpTV8c4UnUMyEjyb2hee1YXg@mail.gmail.com>
[not found] ` <CAFftDdpeP39qvXNTe06EWkc3Kp_TMu5bGOf8WN6Q-k2Cehn_3w@mail.gmail.com>
2020-02-28 19:05 ` Stephen Smalley [this message]
2020-03-01 20:04 ` Nicolas Iooss
2020-02-28 15:48 ` [PATCH v3 4/4] libselinux: drop symbols from map bill.c.roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEjxPJ7tt7T1NaYcG6B+k9smtcjrM0WXQXDXjnx5A=FNPLPt4w@mail.gmail.com' \
--to=stephen.smalley.work@gmail.com \
--cc=bill.c.roberts@gmail.com \
--cc=drepper@redhat.com \
--cc=omosnace@redhat.com \
--cc=plautrba@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).