From: William Roberts <bill.c.roberts@gmail.com>
To: yuli.khodorkovskiy@crunchydata.com
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH v2 1/1] libsemanage: improve semanage_migrate_store import failure
Date: Thu, 11 Oct 2018 07:55:07 -0700 [thread overview]
Message-ID: <CAFftDdqsUvS2X_AT8aaguQX4n4sW1zH_v+y6LyM2DwQk7XMg=g@mail.gmail.com> (raw)
In-Reply-To: <CAFftDdqagQZbbccJGQ+GB23kF9g_ZuiA3RN9psB7qykt+XhGjw@mail.gmail.com>
Merged: https://github.com/SELinuxProject/selinux/pull/102
Sorry I got over-zealous and did this under the 24 hour requirement.
Considering the
one liner and that v1 had review and no one objected to the change I don't see
it as a big issue. My mistake.
On Thu, Oct 11, 2018 at 7:19 AM William Roberts
<bill.c.roberts@gmail.com> wrote:
>
> On Thu, Oct 11, 2018 at 6:45 AM Yuli Khodorkovskiy
> <yuli.khodorkovskiy@crunchydata.com> wrote:
> >
> > From: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>
> >
> > The selinux/semanage python module import error in semanage_migrate_store
> > was misleading. Before, it would report that the selinux/semanage modules
> > were not installed even though they were on the system.
> >
> > Now the import failure is only reported if the modules are not installed.
> > Otherwise, a stack trace is printed for all other errors in the selinux/semanage
> > python modules.
> >
> > Signed-off-by: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>
> > ---
> > libsemanage/utils/semanage_migrate_store | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libsemanage/utils/semanage_migrate_store b/libsemanage/utils/semanage_migrate_store
> > index 2e6cb278..b789d042 100755
> > --- a/libsemanage/utils/semanage_migrate_store
> > +++ b/libsemanage/utils/semanage_migrate_store
> > @@ -15,7 +15,7 @@ sepol = ctypes.cdll.LoadLibrary('libsepol.so.1')
> > try:
> > import selinux
> > import semanage
> > -except:
> > +except ImportError:
> > print("You must install libselinux-python and libsemanage-python before running this tool", file=sys.stderr)
> > exit(1)
> >
> > --
> > 2.19.0
> >
>
> ack
>
> > _______________________________________________
> > Selinux mailing list
> > Selinux@tycho.nsa.gov
> > To unsubscribe, send email to Selinux-leave@tycho.nsa.gov.
> > To get help, send an email containing "help" to Selinux-request@tycho.nsa.gov.
prev parent reply other threads:[~2018-10-11 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 13:43 [PATCH v2 0/1] Modify exception handling in semanage_migrate_store Yuli Khodorkovskiy
2018-10-11 13:43 ` [PATCH v2 1/1] libsemanage: improve semanage_migrate_store import failure Yuli Khodorkovskiy
2018-10-11 14:19 ` William Roberts
2018-10-11 14:55 ` William Roberts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFftDdqsUvS2X_AT8aaguQX4n4sW1zH_v+y6LyM2DwQk7XMg=g@mail.gmail.com' \
--to=bill.c.roberts@gmail.com \
--cc=selinux@vger.kernel.org \
--cc=yuli.khodorkovskiy@crunchydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).