selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Ethan Edwards <ethancarteredwards@gmail.com>
Cc: Stephen Smalley <stephen.smalley.work@gmail.com>,
	selinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning
Date: Thu, 9 Jul 2020 14:09:57 -0400	[thread overview]
Message-ID: <CAHC9VhSXfo6-S1awsPdj-Zm5Bj+Na1ZgDUi-2XqS7ASVP=+mKA@mail.gmail.com> (raw)
In-Reply-To: <20200709131111.4mqrge6vjsbfs7ls@archlaptop.localdomain>

On Thu, Jul 9, 2020 at 9:11 AM Ethan Edwards
<ethancarteredwards@gmail.com> wrote:
>
> `sizeof buf` changed to `sizeof(buf)`
>
> Signed-off-by: Ethan Edwards <ethancarteredwards@gmail.com>
> ---
>  security/selinux/ss/conditional.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Why are you reposting this when I applied your original patch last week?

https://lore.kernel.org/selinux/CAHC9VhSakA7V99+tkvLLZHohiupWmjSFxSZLWZT4-Gwr5Cc-XA@mail.gmail.com

> diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
> index 0cc7cdd58465..90a2f5927e55 100644
> --- a/security/selinux/ss/conditional.c
> +++ b/security/selinux/ss/conditional.c
> @@ -215,7 +215,7 @@ int cond_read_bool(struct policydb *p, struct hashtab *h, void *fp)
>         if (!booldatum)
>                 return -ENOMEM;
>
> -       rc = next_entry(buf, fp, sizeof buf);
> +       rc = next_entry(buf, fp, sizeof(buf));
>         if (rc)
>                 goto err;
>
> @@ -416,7 +416,7 @@ int cond_read_list(struct policydb *p, void *fp)
>         u32 i, len;
>         int rc;
>
> -       rc = next_entry(buf, fp, sizeof buf);
> +       rc = next_entry(buf, fp, sizeof(buf));
>         if (rc)
>                 return rc;
>
> --
> 2.27.0
>


-- 
paul moore
www.paul-moore.com

  reply	other threads:[~2020-07-09 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 13:11 [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning Ethan Edwards
2020-07-09 18:09 ` Paul Moore [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-06-24 16:12 Ethan Edwards
2020-06-29 23:28 ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHC9VhSXfo6-S1awsPdj-Zm5Bj+Na1ZgDUi-2XqS7ASVP=+mKA@mail.gmail.com' \
    --to=paul@paul-moore.com \
    --cc=ethancarteredwards@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=selinux@vger.kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).