From: Nicolas Iooss <nicolas.iooss@m4x.org>
To: "W. Michael Petullo" <mike@flyn.org>
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH] python/audit2allow: add #include <limits.h> to sepolgen-ifgen-attr-helper.c
Date: Sun, 19 Jul 2020 18:43:34 +0200 [thread overview]
Message-ID: <CAJfZ7=kxW1zaROh_9rC8-CCafBciFXmFfKFh0B0fwwGYCTp6Lg@mail.gmail.com> (raw)
In-Reply-To: <51d7bd5e067978ea5340ee408a7329e8b921b372.camel@flyn.org>
On Thu, Jul 16, 2020 at 10:39 PM W. Michael Petullo <mike@flyn.org> wrote:
>
> I found that building on OpenWrt/musl failed with:
>
> sepolgen-ifgen-attr-helper.c:152:16: error: 'PATH_MAX' undeclared ...
>
> Musl is less "generous" than glibc in recursively including header
> files, and I suspect this is the reason for this error. Explicitly
> including limits.h fixes the problem.
>
> Signed-off-by: W. Michael Petullo <mike@flyn.org>
> ---
> python/audit2allow/sepolgen-ifgen-attr-helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/python/audit2allow/sepolgen-ifgen-attr-helper.c
> b/python/audit2allow/sepolgen-ifgen-attr-helper.c
> index 53f20818..f010c958 100644
> --- a/python/audit2allow/sepolgen-ifgen-attr-helper.c
> +++ b/python/audit2allow/sepolgen-ifgen-attr-helper.c
> @@ -28,6 +28,7 @@
>
> #include <selinux/selinux.h>
>
> +#include <limits.h>
> #include <stdio.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> --
> 2.26.2
Looks good to me. Nevertheless I had some trouble applying your patch
using "git am" because your message contained
"b/python/audit2allow/sepolgen-ifgen-attr-helper.c" on a new line. Did
you use "git send-email" or something similar, to send your patch?
Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
If nobody complains, I will apply this patch tomorrow.
Thanks,
Nicolas
next prev parent reply other threads:[~2020-07-19 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 20:29 [PATCH] python/audit2allow: add #include <limits.h> to sepolgen-ifgen-attr-helper.c W. Michael Petullo
2020-07-19 16:43 ` Nicolas Iooss [this message]
2020-07-21 6:35 ` Nicolas Iooss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfZ7=kxW1zaROh_9rC8-CCafBciFXmFfKFh0B0fwwGYCTp6Lg@mail.gmail.com' \
--to=nicolas.iooss@m4x.org \
--cc=mike@flyn.org \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).