From: jwcart2 <jwcart2@tycho.nsa.gov>
To: Ondrej Mosnacek <omosnace@redhat.com>, selinux@vger.kernel.org
Subject: Re: [Non-DoD Source] [PATCH userspace v2 4/4] Makefile: always build with -fno-common
Date: Thu, 23 Jan 2020 13:26:46 -0500 [thread overview]
Message-ID: <fb745330-9f6d-b4e4-93de-c7be8a3991bd@tycho.nsa.gov> (raw)
In-Reply-To: <20200123125716.12662-5-omosnace@redhat.com>
On 1/23/20 7:57 AM, Ondrej Mosnacek wrote:
> GCC 10 has it enabled by default and everything now builds OK with it,
> so add it to CFLAGS to avoid breaking the build in the future.
>
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
For all four patches,
Acked-by: James Carter <jwcart2@tycho.nsa.gov>
> ---
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index c238dbc8..298cd2b7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -16,7 +16,8 @@ else
> -Wstrict-prototypes \
> -Wundef \
> -Wunused \
> - -Wwrite-strings
> + -Wwrite-strings \
> + -fno-common
> endif
>
> ifneq ($(DESTDIR),)
>
--
James Carter <jwcart2@tycho.nsa.gov>
National Security Agency
next prev parent reply other threads:[~2020-01-23 18:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 12:57 [PATCH userspace v2 0/4] Fix build with -fno-common Ondrej Mosnacek
2020-01-23 12:57 ` [PATCH userspace v2 1/4] libsepol: fix CIL_KEY_* build errors " Ondrej Mosnacek
2020-01-23 12:57 ` [PATCH userspace v2 2/4] libsepol: remove leftovers of cil_mem_error_handler Ondrej Mosnacek
2020-01-23 12:57 ` [PATCH userspace v2 3/4] checkpolicy: remove unused te_assertions Ondrej Mosnacek
2020-01-23 12:57 ` [PATCH userspace v2 4/4] Makefile: always build with -fno-common Ondrej Mosnacek
2020-01-23 18:26 ` jwcart2 [this message]
2020-01-28 9:54 ` Petr Lautrbach
2020-01-24 10:39 ` [PATCH userspace v2 0/4] Fix " Jason Zaman
2020-01-24 11:15 ` Ondrej Mosnacek
2020-01-27 15:56 ` [Non-DoD Source] " jwcart2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb745330-9f6d-b4e4-93de-c7be8a3991bd@tycho.nsa.gov \
--to=jwcart2@tycho.nsa.gov \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).