From: Christoph Hellwig <hch@lst.de>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Christoph Hellwig <hch@lst.de>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Sparc kernel list <sparclinux@vger.kernel.org>,
debian-sparc <debian-sparc@lists.debian.org>,
Frank Scheiner <frank.scheiner@web.de>
Subject: Re: Regression in 028abd92 for Sun UltraSPARC T1
Date: Tue, 23 Mar 2021 17:57:21 +0100 [thread overview]
Message-ID: <20210323165721.GA14577@lst.de> (raw)
In-Reply-To: <n0n38p9-rn4s-213-n983-9o3o4oo8s54r@vanv.qr>
On Tue, Mar 23, 2021 at 05:50:59PM +0100, Jan Engelhardt wrote:
> Some participants in the discussion over at the debian-sparc list mentioned
> "NFS" and "Invalid argument", which is something I know just too well from
> iptables. NFS is a filesystem that uses an extra data blob (5th argument to the
> mount syscall). Such blobs have historically not always been designed to bear
> the same layout between ILP32 and LP64 modes, and nfs's structs fell prey to
> this as well.
>
> My hypothesis now is that fs/nfs/fs_context.c line 1160:
>
> if (in_compat_syscall())
> nfs4_compat_mount_data_conv(data);
>
> and ones similar to it (I didn't look too close where nfs3 gets to do its
> conversion), no longer trigger as a result of compat_sys_mount being
> wiped from the syscall table:
No, if in_compat_syscall() syscall doesn't trigger properly the kernel
would not get this far.
That being said, the NFS compat code was moved out of the compat mount
handler and into nfs and refactored in the commit just before this one.
Frank, can you double check that commit
67e306c6906137020267eb9bbdbc127034da3627 really still works, and
only 028abd9222df0cf5855dab5014a5ebaf06f90565 broke your setup?
next prev parent reply other threads:[~2021-03-23 16:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 21:30 Regression in 028abd92 for Sun UltraSPARC T1 Frank Scheiner
2021-03-22 21:48 ` John Paul Adrian Glaubitz
2021-03-22 21:55 ` Frank Scheiner
2021-03-23 16:50 ` Jan Engelhardt
2021-03-23 16:57 ` Christoph Hellwig [this message]
2021-03-23 17:39 ` Frank Scheiner
2021-03-23 22:17 ` Frank Scheiner
2021-03-24 8:28 ` Christoph Hellwig
2021-03-24 12:30 ` Frank Scheiner
2021-03-24 12:42 ` Anatoly Pugachev
2021-03-24 12:48 ` Frank Scheiner
2021-03-24 12:49 ` John Paul Adrian Glaubitz
2021-03-24 13:09 ` Frank Scheiner
2021-03-24 13:16 ` John Paul Adrian Glaubitz
2021-03-24 13:19 ` Frank Scheiner
2021-03-24 13:24 ` Anatoly Pugachev
2021-03-24 13:29 ` Frank Scheiner
2021-03-24 13:57 ` Frank Scheiner
2021-03-24 15:22 ` Jan Engelhardt
2021-03-24 15:58 ` Frank Scheiner
2021-03-24 16:10 ` Christoph Hellwig
2021-03-24 16:33 ` Frank Scheiner
2021-03-24 16:37 ` Frank Scheiner
2021-03-25 7:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323165721.GA14577@lst.de \
--to=hch@lst.de \
--cc=debian-sparc@lists.debian.org \
--cc=frank.scheiner@web.de \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jengelh@inai.de \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).