From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hui Wang <hui.wang@canonical.com>,
alsa-devel@alsa-project.org, tiwai@suse.de
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] Revert "ALSA: hda: call runtime_allow() for all hda controllers"
Date: Mon, 3 Aug 2020 10:27:12 -0500 [thread overview]
Message-ID: <0db4f5fe-7895-2d00-8ce3-96f1245000ab@linux.intel.com> (raw)
In-Reply-To: <20200803064638.6139-1-hui.wang@canonical.com>
On 8/3/20 1:46 AM, Hui Wang wrote:
> This reverts commit 9a6418487b56 ("ALSA: hda: call runtime_allow()
> for all hda controllers").
>
> The reverted patch already introduced some regressions on some
> machines:
> - on gemini-lake machines, the error of "azx_get_response timeout"
> happens in the hda driver.
> - on the machines with alc662 codec, the audio jack detection doesn't
> work anymore.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208511
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
> sound/pci/hda/hda_intel.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index e699873c8293..e34a4d5d047c 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2352,7 +2352,6 @@ static int azx_probe_continue(struct azx *chip)
>
> if (azx_has_pm_runtime(chip)) {
> pm_runtime_use_autosuspend(&pci->dev);
> - pm_runtime_allow(&pci->dev);
> pm_runtime_put_autosuspend(&pci->dev);
> }
Do I get this right that this permanently disables pm_runtime on all
Intel HDaudio controllers?
next prev parent reply other threads:[~2020-08-03 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 6:46 [PATCH] Revert "ALSA: hda: call runtime_allow() for all hda controllers" Hui Wang
2020-08-03 7:30 ` Takashi Iwai
2020-08-03 15:27 ` Pierre-Louis Bossart [this message]
2020-08-03 16:36 ` Takashi Iwai
2020-08-03 17:00 ` Pierre-Louis Bossart
2020-08-03 17:40 ` Takashi Iwai
2020-08-03 17:50 ` Pierre-Louis Bossart
2020-08-04 0:21 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0db4f5fe-7895-2d00-8ce3-96f1245000ab@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).