From: Daniel Thompson <daniel.thompson@linaro.org>
To: Jason Wessel <jason.wessel@windriver.com>,
Douglas Anderson <dianders@chromium.org>,
Daniel Thompson <daniel.thompson@linaro.org>
Cc: kgdb-bugreport@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Justin Stitt <justinstitt@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v3 0/7] kdb: Refactor and fix bugs in kdb_read()
Date: Fri, 26 Apr 2024 18:24:35 +0100 [thread overview]
Message-ID: <171415227516.138568.15976914533950726973.b4-ty@linaro.org> (raw)
In-Reply-To: <20240424-kgdb_read_refactor-v3-0-f236dbe9828d@linaro.org>
On Wed, 24 Apr 2024 15:03:33 +0100, Daniel Thompson wrote:
> Inspired by a patch from [Justin][1] I took a closer look at kdb_read().
>
> Despite Justin's patch being a (correct) one-line manipulation it was a
> tough patch to review because the surrounding code was hard to read and
> it looked like there were unfixed problems.
>
> This series isn't enough to make kdb_read() beautiful but it does make
> it shorter, easier to reason about and fixes two buffer overflows and a
> screen redraw problem!
>
> [...]
Applied, thanks!
[1/7] kdb: Fix buffer overflow during tab-complete
commit: e9730744bf3af04cda23799029342aa3cddbc454
[2/7] kdb: Use format-strings rather than '\0' injection in kdb_read()
commit: 09b35989421dfd5573f0b4683c7700a7483c71f9
[3/7] kdb: Fix console handling when editing and tab-completing commands
commit: db2f9c7dc29114f531df4a425d0867d01e1f1e28
[4/7] kdb: Merge identical case statements in kdb_read()
commit: 6244917f377bf64719551b58592a02a0336a7439
[5/7] kdb: Use format-specifiers rather than memset() for padding in kdb_read()
commit: c9b51ddb66b1d96e4d364c088da0f1dfb004c574
[6/7] kdb: Replace double memcpy() with memmove() in kdb_read()
commit: 80bd73c154e3063c4f9293163daf3262335f9f86
[7/7] kdb: Simplify management of tmpbuffer in kdb_read()
commit: 64d504cfcd514743aaed3a5b79c060f0143149e9
Best regards,
--
Daniel Thompson <daniel.thompson@linaro.org>
prev parent reply other threads:[~2024-04-26 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 14:03 [PATCH v3 0/7] kdb: Refactor and fix bugs in kdb_read() Daniel Thompson
2024-04-24 14:03 ` [PATCH v3 1/7] kdb: Fix buffer overflow during tab-complete Daniel Thompson
2024-04-24 14:03 ` [PATCH v3 2/7] kdb: Use format-strings rather than '\0' injection in kdb_read() Daniel Thompson
2024-04-24 14:03 ` [PATCH v3 3/7] kdb: Fix console handling when editing and tab-completing commands Daniel Thompson
2024-04-24 14:03 ` [PATCH v3 4/7] kdb: Merge identical case statements in kdb_read() Daniel Thompson
2024-04-24 14:03 ` [PATCH v3 5/7] kdb: Use format-specifiers rather than memset() for padding " Daniel Thompson
2024-04-26 17:24 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171415227516.138568.15976914533950726973.b4-ty@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=justinstitt@google.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).