stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Evan Green <evgreen@google.com>
Cc: "He, Bo" <bo.he@intel.com>,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Sam Protsenko <semen.protsenko@linaro.org>,
	Doug Anderson <dianders@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>
Subject: Re: Backporting dwc3 gadget fixes
Date: Tue, 29 Jan 2019 11:22:10 +0100	[thread overview]
Message-ID: <20190129102210.GA12232@kroah.com> (raw)
In-Reply-To: <CAE=gft6ewjrSAReGZyFmrZnB0wEDhZu7N_GX5vsqbC3fo+z0TA@mail.gmail.com>

On Wed, Jan 23, 2019 at 10:46:52AM -0800, Evan Green wrote:
> Hi Felipe,
> Well, I've only tried on the one device that has a dwc3 controller.
> Given that the bug was "scheduling while atomic", the stack trace
> always had dwc3_gadget_ep_dequeue doing the sleeping, and it only
> happened when I had a gadget plugged in, I felt pretty solid that this
> was the same bug.
> 
> Also, Matthias pointed out I was looking at an older series when I was
> figuring out which patches went together. Check my work, but the
> series seems to be here:
> https://patchwork.kernel.org/project/linux-usb/list/?series=42875
> 
> The first 3 patches are already backported. Then there were a couple
> extra I had missed before. So the complete set would look like:
> 
> d53701067f04 usb: dwc3: gadget: check if dep->frame_number is still valid
> 3451f6affaef usb: dwc3: gadget: remove unnecessary dev_info()
> 1517265228b4 usb: dwc3: trace: log ep commands in hex
> 25abad6a0584 usb: dwc3: gadget: return errors from __dwc3_gadget_start_isoc()
> fec9095bdef4e usb: dwc3: gadget: remove wait_end_transfer
> d4f1afe5e896c usb: dwc3: gadget: move requests to cancelled_list
> d5443bbf5fc8f usb: dwc3: gadget: introduce cancelled_list
> 7746a8dfb3f9c usb: dwc3: gadget: extract dwc3_gadget_ep_skip_trbs()
> c3acd59014148 usb: dwc3: gadget: use num_trbs when skipping TRBs on ->dequeue()
> 09fe1f8d7e2f4 usb: dwc3: gadget: track number of TRBs per request
> 1a22ec6435806 usb: dwc3: gadget: combine unaligned and zero flags
> 
> Though perhaps only the stuff up through "move requests to
> cancelled_list" is the important stuff... Felipe might be able to say
> better.

Can someone send me a correct list of exactly what patches to commit, to
what kernel tree(s), and in what order?  Ideally you would have also
tested them yourself...

As it is, this "random list of commits" doesn't make me feel good about
backporting.

thanks,

greg k-h

  reply	other threads:[~2019-01-29 10:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23  0:37 Backporting dwc3 gadget fixes Evan Green
2019-01-23  6:32 ` Felipe Balbi
2019-01-23  6:55   ` He, Bo
2019-01-23 18:46     ` Evan Green
2019-01-29 10:22       ` Greg KH [this message]
2019-01-29 19:15         ` Evan Green
2019-02-04  9:11           ` Greg KH
2019-02-04 21:13             ` Evan Green
2019-02-11 13:41               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129102210.GA12232@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bo.he@intel.com \
    --cc=dianders@chromium.org \
    --cc=evgreen@google.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=mka@chromium.org \
    --cc=semen.protsenko@linaro.org \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).