From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 944C9C76186 for ; Wed, 24 Jul 2019 20:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D2312054F for ; Wed, 24 Jul 2019 20:32:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564000342; bh=n+HJGhy/XIG9zr8J9IigWldNrdf5da/92E9wKCkztKc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nNOZhCGGYpjoR9iDiOv4CR/Lw/+QqziV5wuYTFNbd+TClQ9TqFg+HMxJVc3VHGaWG +k2jjVn5QeFFlgV3SOA1ntrEkKzCqN0jOtm83St/6WQiYxL1/aTLh6vGbi77JQcy0I E+FYnQAgyBDc+XybTGRejIhzlHcyTPnDJIkpy9ZQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387825AbfGXT3G (ORCPT ); Wed, 24 Jul 2019 15:29:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:48014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387803AbfGXT3G (ORCPT ); Wed, 24 Jul 2019 15:29:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A0C6B229F3; Wed, 24 Jul 2019 19:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563996545; bh=n+HJGhy/XIG9zr8J9IigWldNrdf5da/92E9wKCkztKc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q/FtDNta1sJbp2J2x+XnCiHpef9W1cWAVZ6jNb8Dw+1cCaqdb63FRzFe1hACNOAx0 7pjTs3EMUeI80Dc1z/3wIoIeyCsSsiakFXr6eeokymy9a/VskPWZJHESv5b7hLrtMa BMgLhifZ2jwr6jVaR5ZwZtIZXtuYXsVCqz4O8SpA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , =?UTF-8?q?Matias=20Bj=C3=B8rling?= , Jens Axboe , Sasha Levin Subject: [PATCH 5.2 135/413] lightnvm: fix uninitialized pointer in nvm_remove_tgt() Date: Wed, 24 Jul 2019 21:17:06 +0200 Message-Id: <20190724191744.666619139@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191735.096702571@linuxfoundation.org> References: <20190724191735.096702571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 2f5af4ab7de14bd35f3435e6a47300276bbb6c17 ] With gcc 4.1: drivers/lightnvm/core.c: In function ‘nvm_remove_tgt’: drivers/lightnvm/core.c:510: warning: ‘t’ is used uninitialized in this function Indeed, if no NVM devices have been registered, t will be an uninitialized pointer, and may be dereferenced later. A call to nvm_remove_tgt() can be triggered from userspace by issuing the NVM_DEV_REMOVE ioctl on the lightnvm control device. Fix this by preinitializing t to NULL. Fixes: 843f2edbdde085b4 ("lightnvm: do not remove instance under global lock") Signed-off-by: Geert Uytterhoeven Signed-off-by: Matias Bjørling Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/lightnvm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index 7d555b110ecd..a600934fdd9c 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -478,7 +478,7 @@ static void __nvm_remove_target(struct nvm_target *t, bool graceful) */ static int nvm_remove_tgt(struct nvm_ioctl_remove *remove) { - struct nvm_target *t; + struct nvm_target *t = NULL; struct nvm_dev *dev; down_read(&nvm_lock); -- 2.20.1