From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3A58C76186 for ; Wed, 24 Jul 2019 20:29:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0CCD204EC for ; Wed, 24 Jul 2019 20:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564000146; bh=PgKnROCQHhUXgNF+sEJkwgBPQQeZ1guqkKm9GmCfoGk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OntnIKt9WLTarP8L9qbSYoMz6G7OLNqHYTDj40WBD31s+9MzUajgvs3Lb5g4mHYZo gY+L4LS1sm6vTTwYETUvxc7sxsQ/wTJHBXLTF2T4nFJLY0yBeRPyTNg+OGhzQ7llr1 7Oi4DaVr3XaqTJ5nv0p7JqALgy7HcaJAo7lrrHoc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388515AbfGXTdn (ORCPT ); Wed, 24 Jul 2019 15:33:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:55616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388899AbfGXTdm (ORCPT ); Wed, 24 Jul 2019 15:33:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20455229F4; Wed, 24 Jul 2019 19:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563996821; bh=PgKnROCQHhUXgNF+sEJkwgBPQQeZ1guqkKm9GmCfoGk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MDJJbP0KcrYOV6848DwLXdL+U8952TGaxDuJI1vEL24tV2+wQk45P7Ml2BZQKqHo2 iHHEnbeY0ED5u9uGFFyZ+DzxIk8tlnEHZoYbgjzpdcPPNHMnB6vKrcnxfN1PAJ2OI+ fl7lE6yQR+1aheVUcjtvV/zzmJcQsIkl+jTjpuVU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomas Bortoli , syzbot+98162c885993b72f19c4@syzkaller.appspotmail.com, Marcel Holtmann , Sasha Levin Subject: [PATCH 5.2 228/413] Bluetooth: hci_bcsp: Fix memory leak in rx_skb Date: Wed, 24 Jul 2019 21:18:39 +0200 Message-Id: <20190724191751.299627738@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191735.096702571@linuxfoundation.org> References: <20190724191735.096702571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 4ce9146e0370fcd573f0372d9b4e5a211112567c ] Syzkaller found that it is possible to provoke a memory leak by never freeing rx_skb in struct bcsp_struct. Fix by freeing in bcsp_close() Signed-off-by: Tomas Bortoli Reported-by: syzbot+98162c885993b72f19c4@syzkaller.appspotmail.com Signed-off-by: Marcel Holtmann Signed-off-by: Sasha Levin --- drivers/bluetooth/hci_bcsp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c index 82b13faa9422..fe2e307009f4 100644 --- a/drivers/bluetooth/hci_bcsp.c +++ b/drivers/bluetooth/hci_bcsp.c @@ -744,6 +744,11 @@ static int bcsp_close(struct hci_uart *hu) skb_queue_purge(&bcsp->rel); skb_queue_purge(&bcsp->unrel); + if (bcsp->rx_skb) { + kfree_skb(bcsp->rx_skb); + bcsp->rx_skb = NULL; + } + kfree(bcsp); return 0; } -- 2.20.1