From: Emil Velikov <emil.l.velikov@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: john.p.donnelly@oracle.com, "David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
"Andrzej Pietrasiewicz" <andrzej.p@collabora.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"José Roberto de Souza" <jose.souza@intel.com>,
"Dave Airlie" <airlied@redhat.com>,
"# 3.13+" <stable@vger.kernel.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v2 1/3] drm/mgag200: Extract device type from flags
Date: Thu, 28 Nov 2019 12:46:03 +0000 [thread overview]
Message-ID: <20191128124603.GA9293@arch-x1c3> (raw)
In-Reply-To: <98068118-8988-e31a-11c3-17a88059fbed@suse.de>
On 2019/11/27, Thomas Zimmermann wrote:
> Hi Emil
>
> Am 27.11.19 um 17:29 schrieb Emil Velikov:
> > Hi Thomas,
> >
> > On Tue, 26 Nov 2019 at 10:15, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> >>
> >> Adds a conversion function that extracts the device type from the
> >> PCI id-table flags. Allows for storing additional information in the
> >> other flag bits.
> >>
> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> >> Fixes: 81da87f63a1e ("drm: Replace drm_gem_vram_push_to_system() with kunmap + unpin")
> >
> > Are you sure the fixes tag is correct? Neither the commit summary nor
> > the patch itself seems related to the changes below.
>
> Yes, it's correct. It's part of a patch series [1][2][3] that fixes the bug.
>
> Best regards
> Thomas
>
> [1]
> https://cgit.freedesktop.org/drm/drm-tip/commit/?id=3a8a5aba142a44eaeba0cb0ec1b4a8f177b5e59a
> [2]
> https://cgit.freedesktop.org/drm/drm-tip/commit/?id=d6d437d97d54c85a1a93967b2745e31dff03365a
> [3]
> https://cgit.freedesktop.org/drm/drm-tip/commit/?id=1591fadf857cdbaf2baa55e421af99a61354713c
>
I see, different alignment is required for one mga200 GPU.
Personally, I would have mentioned that in the commit message.
Regardless, hats off for the prompt fixup.
Thanks
Emil
next prev parent reply other threads:[~2019-11-28 12:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191126101529.20356-1-tzimmermann@suse.de>
2019-11-26 10:15 ` [PATCH v2 1/3] drm/mgag200: Extract device type from flags Thomas Zimmermann
2019-11-27 16:29 ` Emil Velikov
2019-11-27 18:08 ` Thomas Zimmermann
2019-11-28 12:46 ` Emil Velikov [this message]
2019-11-26 10:15 ` [PATCH v2 2/3] drm/mgag200: Store flags from PCI driver data in device structure Thomas Zimmermann
2019-11-26 10:15 ` [PATCH v2 3/3] drm/mgag200: Add workaround for HW that does not support 'startadd' Thomas Zimmermann
[not found] ` <20191128142337.1B32A217F5@mail.kernel.org>
2019-12-03 17:30 ` FAILED - " John Donnelly
2019-12-06 0:48 ` John Donnelly
2019-12-06 6:02 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128124603.GA9293@arch-x1c3 \
--to=emil.l.velikov@gmail.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=andrzej.p@collabora.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=john.p.donnelly@oracle.com \
--cc=jose.souza@intel.com \
--cc=kraxel@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=sam@ravnborg.org \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).