From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AFC3C43603 for ; Wed, 4 Dec 2019 18:12:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DDC820862 for ; Wed, 4 Dec 2019 18:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575483174; bh=oqoXrjybaQcbpavSA2Ct70GdEPmxLqSSsipp5kfREaw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RgqfU5h0SN1Tz993Q86CCC20GHYNt7U7ovPJktqSkbL9MbAJ08knzE5tlAqDVGorR 2aI0zHAYlnsAnYmHMEvQi+fs6fVjpeztbnU7Jf4WDHlTxad+HoYk7fxNdH/R6ZuX3F uDy6vfnXnRVnRxVRGYP2M27FAc1l6Z2/ipmScVEM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730996AbfLDSMx (ORCPT ); Wed, 4 Dec 2019 13:12:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:41738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730887AbfLDSMw (ORCPT ); Wed, 4 Dec 2019 13:12:52 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3047920674; Wed, 4 Dec 2019 18:12:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575483171; bh=oqoXrjybaQcbpavSA2Ct70GdEPmxLqSSsipp5kfREaw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mnT7gSI7ft5IHVRk54op0+KdA+7sIkw+e4oWgF9tiuTWyTXIoNusIjsSo1fK+Vs5s F8EUdscbbXMyVheA+1gNZfa2OeSOyRB06x1IpscgFI+xuzK7OKX3unFNsFTyqIo2EM /mKkSV1UvDRO1c6ycEONfW0PE8XYZjcuyzoo2I58= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 079/125] tipc: fix a missing check of genlmsg_put Date: Wed, 4 Dec 2019 18:56:24 +0100 Message-Id: <20191204175323.831905702@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175308.377746305@linuxfoundation.org> References: <20191204175308.377746305@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kangjie Lu [ Upstream commit 46273cf7e009231d2b6bc10a926e82b8928a9fb2 ] genlmsg_put could fail. The fix inserts a check of its return value, and if it fails, returns -EMSGSIZE. Signed-off-by: Kangjie Lu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/tipc/netlink_compat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 63a913b238735..454ed8ea194c8 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -974,6 +974,8 @@ static int tipc_nl_compat_publ_dump(struct tipc_nl_compat_msg *msg, u32 sock) hdr = genlmsg_put(args, 0, 0, &tipc_genl_family, NLM_F_MULTI, TIPC_NL_PUBL_GET); + if (!hdr) + return -EMSGSIZE; nest = nla_nest_start(args, TIPC_NLA_SOCK); if (!nest) { -- 2.20.1