From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE00EC33CB1 for ; Thu, 16 Jan 2020 16:52:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C440622464 for ; Thu, 16 Jan 2020 16:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193571; bh=sq5OqsXtfabk0lzYM/DJk5XuO8zXil5wi76LZgBG4NA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Zbc2TvEeR8NmTCSZzZZWZ/VkWRQzh56h61Own5W1Tza8eDJewitxsVK+1SeEx5rbi 5ZWZGGU3rmqBWqHyXNb0yrgm+dCL0PdnNpf9uVD0C3WOnoMz5nbUT+/CecuU3/5baH dBkQ2pqU4DMZalNjQ1YriDdusxNkGInV7ubjfQo4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729565AbgAPQwu (ORCPT ); Thu, 16 Jan 2020 11:52:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:36114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730400AbgAPQwt (ORCPT ); Thu, 16 Jan 2020 11:52:49 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABE8624679; Thu, 16 Jan 2020 16:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193568; bh=sq5OqsXtfabk0lzYM/DJk5XuO8zXil5wi76LZgBG4NA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wThEQS3hdX0VuKK9TNLG5kHbDawjADyoqySukadSK9hxy30CWJs+J27eS4ADIDrXT 8FPok6kVzlPe6xXU5U1T+0jbkLVOGBAsFCPJ9QroSwlcY2rt78MOAU/8vQo8uuiOFf xqq/Uq5McFF3N+CUGxYm96mVJCP1uplQFkOOqOXs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andrii Nakryiko , Daniel Borkmann , Sasha Levin , netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 112/205] libbpf: Fix potential overflow issue Date: Thu, 16 Jan 2020 11:41:27 -0500 Message-Id: <20200116164300.6705-112-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116164300.6705-1-sashal@kernel.org> References: <20200116164300.6705-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Andrii Nakryiko [ Upstream commit 4ee1135615713387b869dfd099ffdf8656be6784 ] Fix a potential overflow issue found by LGTM analysis, based on Github libbpf source code. Fixes: 3d65014146c6 ("bpf: libbpf: Add btf_line_info support to libbpf") Signed-off-by: Andrii Nakryiko Signed-off-by: Daniel Borkmann Link: https://lore.kernel.org/bpf/20191107020855.3834758-3-andriin@fb.com Signed-off-by: Sasha Levin --- tools/lib/bpf/bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c index cbb933532981..9d0485959308 100644 --- a/tools/lib/bpf/bpf.c +++ b/tools/lib/bpf/bpf.c @@ -189,7 +189,7 @@ static void * alloc_zero_tailing_info(const void *orecord, __u32 cnt, __u32 actual_rec_size, __u32 expected_rec_size) { - __u64 info_len = actual_rec_size * cnt; + __u64 info_len = (__u64)actual_rec_size * cnt; void *info, *nrecord; int i; -- 2.20.1