From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A50A8C33CB1 for ; Thu, 16 Jan 2020 16:51:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74DAE20730 for ; Thu, 16 Jan 2020 16:51:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193502; bh=/U6vsz57qdSJa/4AbKCXyUcyEIv3LT/mA9sAA6aZM6c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1N4qVDVQADjEagu1JTRRh4tXrZR9ZDfsi897/tbMbT9FGDhJbw3LAx9uOlx+Kth7B 4DGv5BFV/CAzoZmW/gfxfGkMlC2ZirSTiszVQcZT8b4zPnqc6OH4ig9Wi4UgcaOHM8 od599v7ZYpGjqCd6EFW1Nc9H/3CDweybqhS5GM/Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727026AbgAPQvi (ORCPT ); Thu, 16 Jan 2020 11:51:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:34410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727005AbgAPQvi (ORCPT ); Thu, 16 Jan 2020 11:51:38 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FDC020730; Thu, 16 Jan 2020 16:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193497; bh=/U6vsz57qdSJa/4AbKCXyUcyEIv3LT/mA9sAA6aZM6c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GM5gfN5c0Fhns/bbFFNJN0c7kGrb9Y0w7mpjWQe1FRBLGEZuXI6bKQE5+mQjijlT+ 9wfGkbgNcsh/Jjf7RxsamBxOu8Mahcu9bg9eI9DmGsCKw2HHk/Sz6VfIzCUfFihPMp fHwDvcQTJMvHJL2DoCo5W/pqTS9Aaq9vmm38fUz8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yunfeng Ye , Ard Biesheuvel , Herbert Xu , Sasha Levin , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 091/205] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt() Date: Thu, 16 Jan 2020 11:41:06 -0500 Message-Id: <20200116164300.6705-91-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116164300.6705-1-sashal@kernel.org> References: <20200116164300.6705-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yunfeng Ye [ Upstream commit 9b537997b669c42cec67893538037e8d1c83c91c ] A warning is found by the static code analysis tool: "Identical condition 'err', second condition is always false" Fix this by adding return value of skcipher_walk_done(). Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS") Signed-off-by: Yunfeng Ye Acked-by: Ard Biesheuvel Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- arch/arm64/crypto/aes-neonbs-glue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c index ea873b8904c4..e3e27349a9fe 100644 --- a/arch/arm64/crypto/aes-neonbs-glue.c +++ b/arch/arm64/crypto/aes-neonbs-glue.c @@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt, goto xts_tail; kernel_neon_end(); - skcipher_walk_done(&walk, nbytes); + err = skcipher_walk_done(&walk, nbytes); } if (err || likely(!tail)) -- 2.20.1