From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Michał Stanek" <mst@semihalf.com>
Cc: linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, stanekm@google.com,
stable@vger.kernel.org, Marcin Wojtas <mw@semihalf.com>,
levinale@chromium.org, andriy.shevchenko@linux.intel.com,
Linus Walleij <linus.walleij@linaro.org>,
bgolaszewski@baylibre.com, rafael.j.wysocki@intel.com,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] pinctrl: cherryview: Add quirk with custom translation of ACPI GPIO numbers
Date: Fri, 7 Feb 2020 09:56:54 +0200 [thread overview]
Message-ID: <20200207075654.GB2667@lahna.fi.intel.com> (raw)
In-Reply-To: <CAMiGqYi2rVAc=hepkY-4S1U_3dJdbR4pOoB0f8tbBL4pzWLdxA@mail.gmail.com>
On Thu, Feb 06, 2020 at 11:26:54PM +0100, Michał Stanek wrote:
> On Thu, Feb 6, 2020 at 9:31 AM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > On Wed, Feb 05, 2020 at 08:48:04PM +0100, Michal Stanek wrote:
> > > Dropping custom Linux GPIO translation caused some Intel_Strago based Chromebooks
> > > with old firmware to detect GPIOs incorrectly. Add quirk which restores some code removed by
> > > commit 03c4749dd6c7ff94 ("gpio / ACPI: Drop unnecessary ACPI GPIO to Linux GPIO translation").
> >
> > Hi,
> >
> > Can you elaborate this? I was under the impression that all the
> > different Strago systems have been already worked around by patches from
> > Dmitry (Cc'd).
>
> Hi Mika,
>
> The previous patches from Dmitry handled IRQ numbering, here we have a
> similar issue with GPIO to pin translation - hardcoded values in FW
> which do not agree with the (non-consecutive) numbering in newer
> kernels.
Hmm, so instead of passing GpioIo/GpioInt resources to devices the
firmware uses some hard-coded Linux GPIO numbering scheme? Would you
able to share the exact firmware description where this happens?
> > What GPIO(s) we are talking about and how does it show up to the user?
>
> As an example, the issue manifests itself when you run 'crossystem
> wpsw_cur'. On my Kefka it incorrectly reports the value as 1 instead
> of 0 when the write protect screw is removed.
Is it poking GPIOs directly through sysfs relying the Linux GPIO
numbering (which can change and is fragile anyway)?
next prev parent reply other threads:[~2020-02-07 7:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 19:48 [PATCH] pinctrl: cherryview: Add quirk with custom translation of ACPI GPIO numbers Michal Stanek
2020-02-06 8:31 ` Mika Westerberg
2020-02-06 22:26 ` Michał Stanek
2020-02-07 7:56 ` Mika Westerberg [this message]
2020-02-08 18:43 ` Michał Stanek
2020-02-10 10:14 ` Mika Westerberg
2020-03-10 14:12 ` Michał Stanek
2020-03-10 14:49 ` Mika Westerberg
2020-03-25 22:50 ` Linus Walleij
2020-04-17 2:06 ` Brian Norris
2020-04-17 9:05 ` Mika Westerberg
2020-04-18 0:55 ` Brian Norris
2020-08-18 13:59 ` Andy Shevchenko
2020-02-10 12:13 ` Linus Walleij
2020-02-06 9:25 ` Andy Shevchenko
2020-02-06 18:31 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207075654.GB2667@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=levinale@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@semihalf.com \
--cc=mw@semihalf.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=stanekm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).