From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C02C352A4 for ; Mon, 10 Feb 2020 13:36:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF20820714 for ; Mon, 10 Feb 2020 13:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581341770; bh=bEyUaUJDZWKIaFkm9kfh2NJE6BjbUnwFuAyls7yPOHQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cX6pzPOK9UF2YLVDiy4gwcOLJcbHTUOq+/QIcnBkPha4Wui4nclsGX8Z71GT8dGNU 0uEdejuFxkhO/rS0/+DNj0pJC4H06FcB0zgFEFeUGrBbFcNVzIbzRUyYw51VOcJh79 njEXUY5xisFZppg7DP9MyF8h5gzK1t3V3hocL/nU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730414AbgBJNgJ (ORCPT ); Mon, 10 Feb 2020 08:36:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:51524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727786AbgBJMfN (ORCPT ); Mon, 10 Feb 2020 07:35:13 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F4A620873; Mon, 10 Feb 2020 12:35:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338112; bh=bEyUaUJDZWKIaFkm9kfh2NJE6BjbUnwFuAyls7yPOHQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mako4r0PhuZ3QgeNn8vXvh9DiRmlDeflGwrlFGs3iJQT5tYRRLTMDO/YAQafD7vYT w/cIHpt2l/RWDYAjKyW3xoM7aF7e/SRQr1Q7gU+5qyFj0tBCJWjM6QTnjmx1bXktNq rEW1HQMxUkwpSr1rT4Kp92VD1WOfG0XluuD8kTuw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum , Johan Hovold , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.19 004/195] media: iguanair: fix endpoint sanity check Date: Mon, 10 Feb 2020 04:31:02 -0800 Message-Id: <20200210122306.154693730@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122305.731206734@linuxfoundation.org> References: <20200210122305.731206734@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Johan Hovold [ Upstream commit 1b257870a78b0a9ce98fdfb052c58542022ffb5b ] Make sure to use the current alternate setting, which need not be the first one by index, when verifying the endpoint descriptors and initialising the URBs. Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on. Fixes: 26ff63137c45 ("[media] Add support for the IguanaWorks USB IR Transceiver") Fixes: ab1cbdf159be ("media: iguanair: add sanity checks") Cc: stable # 3.6 Cc: Oliver Neukum Signed-off-by: Johan Hovold Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/rc/iguanair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c index 6f3030b2054d0..1df9522c30fa0 100644 --- a/drivers/media/rc/iguanair.c +++ b/drivers/media/rc/iguanair.c @@ -424,7 +424,7 @@ static int iguanair_probe(struct usb_interface *intf, int ret, pipein, pipeout; struct usb_host_interface *idesc; - idesc = intf->altsetting; + idesc = intf->cur_altsetting; if (idesc->desc.bNumEndpoints < 2) return -ENODEV; -- 2.20.1