From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12B7FC43331 for ; Tue, 24 Mar 2020 13:12:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD227208DB for ; Tue, 24 Mar 2020 13:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585055520; bh=L57iPVKkL097o6qLvQ+L5j2oTFH13RI1AUODGUtvQTY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AAeuAn0SF3zis8lOL/cUn2pn/HJYsvUWqWNrX5d/tw4ZRBz4xZO0OkztyCUvKd0Q+ QL9Z0RRtvOAfc47LxewNjtVxE5nt7LHAUeP+YgentWc4ERoQjpLkJfDYA2TX0fMR/P 6GR6H4NDUPD+EimTGe4PMUKAhXUDyIzvX0neKW78= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727361AbgCXNMA (ORCPT ); Tue, 24 Mar 2020 09:12:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:57428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727304AbgCXNMA (ORCPT ); Tue, 24 Mar 2020 09:12:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9C4DF208CA; Tue, 24 Mar 2020 13:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585055518; bh=L57iPVKkL097o6qLvQ+L5j2oTFH13RI1AUODGUtvQTY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x/U8//LCb86FP5GWagwziMBHZwrMXY6kxPaBOed8H5HX7RaIBuCMN1PE6JnZ4TSnL Ykg3B5E2tpFkTl+R0Nfs1B2qHYVkvDeeM9DhC0Wc12vqP0GtL+kr/KZwtnyano6D3P O2l5DGegvvArZE17NIGzwBGwR/Ttz1nQhPc4+wI4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yuji sasaki , Vinod Koul , Mark Brown , Sasha Levin Subject: [PATCH 4.19 02/65] spi: qup: call spi_qup_pm_resume_runtime before suspending Date: Tue, 24 Mar 2020 14:10:23 +0100 Message-Id: <20200324130757.061144024@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200324130756.679112147@linuxfoundation.org> References: <20200324130756.679112147@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yuji Sasaki [ Upstream commit 136b5cd2e2f97581ae560cff0db2a3b5369112da ] spi_qup_suspend() will cause synchronous external abort when runtime suspend is enabled and applied, as it tries to access SPI controller register while clock is already disabled in spi_qup_pm_suspend_runtime(). Signed-off-by: Yuji sasaki Signed-off-by: Vinod Koul Link: https://lore.kernel.org/r/20200214074340.2286170-1-vkoul@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-qup.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 974a8ce58b68b..cb74fd1af2053 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -1190,6 +1190,11 @@ static int spi_qup_suspend(struct device *device) struct spi_qup *controller = spi_master_get_devdata(master); int ret; + if (pm_runtime_suspended(device)) { + ret = spi_qup_pm_resume_runtime(device); + if (ret) + return ret; + } ret = spi_master_suspend(master); if (ret) return ret; @@ -1198,10 +1203,8 @@ static int spi_qup_suspend(struct device *device) if (ret) return ret; - if (!pm_runtime_suspended(device)) { - clk_disable_unprepare(controller->cclk); - clk_disable_unprepare(controller->iclk); - } + clk_disable_unprepare(controller->cclk); + clk_disable_unprepare(controller->iclk); return 0; } -- 2.20.1