From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 050A5C38A2A for ; Fri, 8 May 2020 12:42:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1A3E24970 for ; Fri, 8 May 2020 12:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588941775; bh=B0THgzLB98z6nynqqw9dkSLS0zUCJgWl0JwEXxMV4wY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=CQa2Atijamd6kxfzju50XDpay5H3s9JRTgYdWA+BLWEs2uQXzjdWInzWm8wzuoKP4 iUfjRTa0aEm4PIMOlBjgD0S1+XXXqK9ijMLfzH0pxftEKCXZ7y/L9I+JTrxC0KXfkN ugmidQbQzAH4dPE6FW0y860EQyaAD6h0l+zEAetU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729000AbgEHMmx (ORCPT ); Fri, 8 May 2020 08:42:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:40228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729013AbgEHMmt (ORCPT ); Fri, 8 May 2020 08:42:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5333324968; Fri, 8 May 2020 12:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588941768; bh=B0THgzLB98z6nynqqw9dkSLS0zUCJgWl0JwEXxMV4wY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mVCK5/de7IfQfBPUYqekn28O1QxlYP6BebX915vJjd5MnxgGBB7x3dNC+H3MXKKQD TAseNxVXAYtXtlnCBgS3Tdpkgy+DeyCH+V6PaHHslFiZI8QNNnTi8dgVfhCY3aC4lw Zio7exRoFG8BuQtGN63q19h2S8QSCKivJ6Ecc+go= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ronnie Sahlberg , Jeff Layton , Steve French , Sasha Levin Subject: [PATCH 4.4 164/312] cifs: protect updating server->dstaddr with a spinlock Date: Fri, 8 May 2020 14:32:35 +0200 Message-Id: <20200508123135.987431711@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200508123124.574959822@linuxfoundation.org> References: <20200508123124.574959822@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Ronnie Sahlberg [ Upstream commit fada37f6f62995cc449b36ebba1220594bfe55fe ] We use a spinlock while we are reading and accessing the destination address for a server. We need to also use this spinlock to protect when we are modifying this address from reconn_set_ipaddr(). Signed-off-by: Ronnie Sahlberg Reviewed-by: Jeff Layton Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/connect.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index cf104bbe30a14..c9793ce0d3368 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -338,8 +338,10 @@ static int reconn_set_ipaddr(struct TCP_Server_Info *server) return rc; } + spin_lock(&cifs_tcp_ses_lock); rc = cifs_convert_address((struct sockaddr *)&server->dstaddr, ipaddr, strlen(ipaddr)); + spin_unlock(&cifs_tcp_ses_lock); kfree(ipaddr); return !rc ? -1 : 0; -- 2.20.1