From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69387C433E4 for ; Mon, 20 Jul 2020 16:26:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45009206E9 for ; Mon, 20 Jul 2020 16:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595262375; bh=ELeIMvO+2n1S5vQap7x4dRHulOLFJ/1t/gDUszZbH+4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=o6gnIbWsdH6L9ljHSdZwuJzVZeEVl5jaxDMaC2ypvHk+ntW7vzNZoI3hoRpm3elXf yRvGt7ITkuHE0NeGOrsivauKR5tA/NbLKqXWWzkAY3MAxJYAW4OVo0o+gAUS5GXFcm P6vdOFyUAG3EOabKr4nG5Wmrg18w4+8Z1RtT6C5I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732410AbgGTQA3 (ORCPT ); Mon, 20 Jul 2020 12:00:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:33464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732406AbgGTQA1 (ORCPT ); Mon, 20 Jul 2020 12:00:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E948A20672; Mon, 20 Jul 2020 16:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595260827; bh=ELeIMvO+2n1S5vQap7x4dRHulOLFJ/1t/gDUszZbH+4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ki7CuZiILw6e1EnD9FjMLfu9+QMvFmtF2MGgXz1Tdjx+hXsg7aH3lFhFFOoINj01c +wSEJE2kQ5cezeThGGtLE6SZH3VJUA+v+2tjp7WdcXKshIaF4g4oSMCSRI8h05Rzcn eCosHGK/fBKL1oGn51O7k8/PefAKUvlRU4FEI+/Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasily Averin , Miklos Szeredi , Sasha Levin Subject: [PATCH 5.4 111/215] fuse: dont ignore errors from fuse_writepages_fill() Date: Mon, 20 Jul 2020 17:36:33 +0200 Message-Id: <20200720152825.479045822@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152820.122442056@linuxfoundation.org> References: <20200720152820.122442056@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vasily Averin [ Upstream commit 7779b047a57f6824a43d0e1f70de2741b7426b9d ] fuse_writepages() ignores some errors taken from fuse_writepages_fill() I believe it is a bug: if .writepages is called with WB_SYNC_ALL it should either guarantee that all data was successfully saved or return error. Fixes: 26d614df1da9 ("fuse: Implement writepages callback") Signed-off-by: Vasily Averin Signed-off-by: Miklos Szeredi Signed-off-by: Sasha Levin --- fs/fuse/file.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 66214707a9456..d5963ef65c389 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -2148,10 +2148,8 @@ static int fuse_writepages(struct address_space *mapping, err = write_cache_pages(mapping, wbc, fuse_writepages_fill, &data); if (data.wpa) { - /* Ignore errors if we can write at least one page */ WARN_ON(!data.wpa->ia.ap.num_pages); fuse_writepages_send(&data); - err = 0; } if (data.ff) fuse_file_put(data.ff, false, false); -- 2.25.1