From: Greg KH <gregkh@linuxfoundation.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: stable@vger.kernel.org, netdev@vger.kernel.org,
madalin.bucur@oss.nxp.com, camelia.groza@nxp.com,
joakim.tjernlund@infinera.com, fido_max@inbox.ru,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 stable-5.4.y] Revert "dpaa_eth: fix usage as DSA master, try 3"
Date: Thu, 30 Jul 2020 09:30:13 +0200 [thread overview]
Message-ID: <20200730073013.GC4045776@kroah.com> (raw)
In-Reply-To: <20200624124517.3212326-1-olteanv@gmail.com>
On Wed, Jun 24, 2020 at 03:45:17PM +0300, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> This reverts commit 40a904b1c2e57b22dd002dfce73688871cb0bac8.
>
> The patch is not wrong, but the Fixes: tag is. It should have been:
>
> Fixes: 060ad66f9795 ("dpaa_eth: change DMA device")
>
> which means that it's fixing a commit which was introduced in:
>
> git tag --contains 060ad66f97954
> v5.5
>
> which then means it should have not been backported to linux-5.4.y,
> where things _were_ working and now they're not.
>
> Reported-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> Changes in v1:
> Adjusted the commit message from linux-4.19.y to linux-5.4.y
>
> Changes in v2:
> Fixed the sha1sum of the reverted commit.
>
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index 6683409fbd4a..4b21ae27a9fd 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -2796,7 +2796,7 @@ static int dpaa_eth_probe(struct platform_device *pdev)
> }
>
> /* Do this here, so we can be verbose early */
> - SET_NETDEV_DEV(net_dev, dev->parent);
> + SET_NETDEV_DEV(net_dev, dev);
> dev_set_drvdata(dev, net_dev);
>
> priv = netdev_priv(net_dev);
> --
> 2.25.1
>
Now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2020-07-30 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 12:45 [PATCH v2 stable-5.4.y] Revert "dpaa_eth: fix usage as DSA master, try 3" Vladimir Oltean
2020-07-30 7:30 ` Greg KH [this message]
2020-07-30 8:25 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730073013.GC4045776@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=camelia.groza@nxp.com \
--cc=fido_max@inbox.ru \
--cc=joakim.tjernlund@infinera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).