From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D82DC433DF for ; Thu, 30 Jul 2020 08:19:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 049162074B for ; Thu, 30 Jul 2020 08:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596097184; bh=iq0cc1HbAjP3ZijxgovlgnyFFQEtr+kzZijALmDgw4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=X8YkeBZpBrd14o2RrSabiXjQBiBb4rT5tt+j9ubcktvY1SJQSI8VvN6CX251NPOXS Wib8fimP9XaQd75jwZb+Gnw0FFSB6WG/knX9T6SFAibqXaJVb+HAD6SS4Z34GdwFf/ h9qGvyxDJywr9xlhTsTpq4jYgNAlet5PwTF8LPh4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729498AbgG3IHv (ORCPT ); Thu, 30 Jul 2020 04:07:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:45870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729512AbgG3IHs (ORCPT ); Thu, 30 Jul 2020 04:07:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40BFA2070B; Thu, 30 Jul 2020 08:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596096466; bh=iq0cc1HbAjP3ZijxgovlgnyFFQEtr+kzZijALmDgw4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yonx/axNkjFZbgrUTsjparbqTrwxWCeR/RQW4PFMcmvmMPP9CrToEwth3ZTI890A0 nac1jCWzbXNTFk73wYzFWYY+ruAqbQM8B3fYxoPQ7MIoXkSMVuPuJBGtEgOuwXHfNk Qwc6lTxHiOyq73EzQIl/AInUnVgDeWtnYoYwyxOE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Peng Fan , Mark Brown Subject: [PATCH 4.14 13/14] regmap: debugfs: check count when read regmap file Date: Thu, 30 Jul 2020 10:04:56 +0200 Message-Id: <20200730074419.551880453@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200730074418.882736401@linuxfoundation.org> References: <20200730074418.882736401@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Peng Fan commit 74edd08a4fbf51d65fd8f4c7d8289cd0f392bd91 upstream. When executing the following command, we met kernel dump. dmesg -c > /dev/null; cd /sys; for i in `ls /sys/kernel/debug/regmap/* -d`; do echo "Checking regmap in $i"; cat $i/registers; done && grep -ri "0x02d0" *; It is because the count value is too big, and kmalloc fails. So add an upper bound check to allow max size `PAGE_SIZE << (MAX_ORDER - 1)`. Signed-off-by: Peng Fan Link: https://lore.kernel.org/r/1584064687-12964-1-git-send-email-peng.fan@nxp.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/base/regmap/regmap-debugfs.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/base/regmap/regmap-debugfs.c +++ b/drivers/base/regmap/regmap-debugfs.c @@ -204,6 +204,9 @@ static ssize_t regmap_read_debugfs(struc if (*ppos < 0 || !count) return -EINVAL; + if (count > (PAGE_SIZE << (MAX_ORDER - 1))) + count = PAGE_SIZE << (MAX_ORDER - 1); + buf = kmalloc(count, GFP_KERNEL); if (!buf) return -ENOMEM; @@ -352,6 +355,9 @@ static ssize_t regmap_reg_ranges_read_fi if (*ppos < 0 || !count) return -EINVAL; + if (count > (PAGE_SIZE << (MAX_ORDER - 1))) + count = PAGE_SIZE << (MAX_ORDER - 1); + buf = kmalloc(count, GFP_KERNEL); if (!buf) return -ENOMEM;