From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A401C433DF for ; Thu, 30 Jul 2020 08:19:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1DA92074B for ; Thu, 30 Jul 2020 08:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596097188; bh=qEFSKF1svw9IjdzOHrzX+VjSPya0UbraoRXCMO0bIu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=q/t9sSx3GFrQu67q29QXc0HXRvgf/I3EerCbp7PbjxpuSZu/4h/4iPuSmyYsLiFB1 O/JnoBWjbncVL1WBcAhS3qZJYdESugKhHgXbAd9do3Zlbv2f2fxSu9IACta9STR/VY Ws6Xlp7KAbU94799N0kxC13jGmRCDhAcsYZlcvIk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729717AbgG3ITo (ORCPT ); Thu, 30 Jul 2020 04:19:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:45900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729121AbgG3IHu (ORCPT ); Thu, 30 Jul 2020 04:07:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3AC8D2083B; Thu, 30 Jul 2020 08:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596096469; bh=qEFSKF1svw9IjdzOHrzX+VjSPya0UbraoRXCMO0bIu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l8qbBqsvKuxbW0dxy6bbxQcCamhbjOzg4J95c+nCzZWZ0K11xBM9Wq0OAX+wx2SEw F+8X0rVckON7BfI2KgyKlTjo/Rp3euhHjV+2RkQgeQsnhUXPllKToJz3Mlvl8gCSnE DEDwRkoHviRxeUcHajX3ufNoHP3Eg+qIiC9f35Z8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Sandeen , Christoph Hellwig , "Darrick J. Wong" , "Nobuhiro Iwamatsu (CIP)" Subject: [PATCH 4.14 14/14] xfs: set format back to extents if xfs_bmap_extents_to_btree Date: Thu, 30 Jul 2020 10:04:57 +0200 Message-Id: <20200730074419.602403976@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200730074418.882736401@linuxfoundation.org> References: <20200730074418.882736401@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Eric Sandeen commit 2c4306f719b083d17df2963bc761777576b8ad1b upstream. If xfs_bmap_extents_to_btree fails in a mode where we call xfs_iroot_realloc(-1) to de-allocate the root, set the format back to extents. Otherwise we can assume we can dereference ifp->if_broot based on the XFS_DINODE_FMT_BTREE format, and crash. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199423 Signed-off-by: Eric Sandeen Reviewed-by: Christoph Hellwig Reviewed-by: Darrick J. Wong Signed-off-by: Darrick J. Wong Signed-off-by: Nobuhiro Iwamatsu (CIP) Signed-off-by: Greg Kroah-Hartman --- fs/xfs/libxfs/xfs_bmap.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/fs/xfs/libxfs/xfs_bmap.c +++ b/fs/xfs/libxfs/xfs_bmap.c @@ -761,12 +761,16 @@ xfs_bmap_extents_to_btree( *logflagsp = 0; if ((error = xfs_alloc_vextent(&args))) { xfs_iroot_realloc(ip, -1, whichfork); + ASSERT(ifp->if_broot == NULL); + XFS_IFORK_FMT_SET(ip, whichfork, XFS_DINODE_FMT_EXTENTS); xfs_btree_del_cursor(cur, XFS_BTREE_ERROR); return error; } if (WARN_ON_ONCE(args.fsbno == NULLFSBLOCK)) { xfs_iroot_realloc(ip, -1, whichfork); + ASSERT(ifp->if_broot == NULL); + XFS_IFORK_FMT_SET(ip, whichfork, XFS_DINODE_FMT_EXTENTS); xfs_btree_del_cursor(cur, XFS_BTREE_ERROR); return -ENOSPC; }