Hi!

> [ Upstream commit e299bcd4d16ff86f46c48df1062c8aae0eca1ed8 ]
> 
> Since commit 6521f8917082 ("namei: prepare for idmapped mounts")
> vfs_link's prototype was changed, the kprobe definition in
> profiler selftest in turn wasn't updated. The result is that all
> argument after the first are now stored in different registers. This
> means that self-test has been broken ever since. Fix it by updating the
> kprobe definition accordingly.

I don't see 6521f8917082 ("namei: prepare for idmapped mounts") in
5.10-stable tree. In 5.10, we still have:

include/linux/fs.h:extern int vfs_link(struct dentry *, struct inode *, struct dentry *, struct inode **);

I believe that means we should not have this one, either.

Best regards,
							Pavel
							
> +++ b/tools/testing/selftests/bpf/progs/profiler.inc.h
> @@ -826,8 +826,9 @@ int kprobe_ret__do_filp_open(struct pt_regs* ctx)
>  
>  SEC("kprobe/vfs_link")
>  int BPF_KPROBE(kprobe__vfs_link,
> -	       struct dentry* old_dentry, struct inode* dir,
> -	       struct dentry* new_dentry, struct inode** delegated_inode)
> +	       struct dentry* old_dentry, struct user_namespace *mnt_userns,
> +	       struct inode* dir, struct dentry* new_dentry,
> +	       struct inode** delegated_inode)
>  {
>  	struct bpf_func_stats_ctx stats_ctx;
>  	bpf_stats_enter(&stats_ctx, profiler_bpf_vfs_link);
> -- 
> 2.35.1
> 
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany