From: "Nadolski, Edmund" <edmund.nadolski@intel.com>
To: Christoph Hellwig <hch@lst.de>,
"Nadolski, Edmund" <edmund.nadolski@intel.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
Ingo Brunberg <ingo_brunberg@web.de>,
stable@vger.kernel.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: Namepace identification descriptor list is optional
Date: Mon, 2 Dec 2019 09:45:30 -0700 [thread overview]
Message-ID: <6ff6ed7f-44f9-5d03-b4d5-2d38e7d16530@intel.com> (raw)
In-Reply-To: <20191202162905.GA7683@lst.de>
On 12/2/2019 9:29 AM, Christoph Hellwig wrote:
> On Mon, Dec 02, 2019 at 09:27:14AM -0700, Nadolski, Edmund wrote:
>>> I don't have such a controller, but many apparently do. The regression
>>> was reported here:
>>>
>>> http://lists.infradead.org/pipermail/linux-nvme/2019-December/028223.html
>>>
>>> And of course it's the SMI controller ...
>>
>> Does 5.4 show the exact error code? Perhaps we should selectively allow
>> just for that case?
>
> They'll find other ways to f***ck up. Looks like at least the controller
> in the bug report also doesn't have an subnqn and the nguid/eui64 are
> bogus. I wonder if we actually do users a favour by allowing that..
Agreed, tho since it looks like a regression, does it make sense to treat as a
quirk?
Ed
next prev parent reply other threads:[~2019-12-02 16:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 15:56 [PATCH] nvme: Namepace identification descriptor list is optional Keith Busch
2019-12-02 16:15 ` Christoph Hellwig
2019-12-02 16:22 ` Keith Busch
2019-12-02 16:27 ` Nadolski, Edmund
2019-12-02 16:29 ` Christoph Hellwig
2019-12-02 16:45 ` Nadolski, Edmund [this message]
2019-12-02 16:49 ` Keith Busch
2019-12-02 17:34 ` Christoph Hellwig
2019-12-02 21:21 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ff6ed7f-44f9-5d03-b4d5-2d38e7d16530@intel.com \
--to=edmund.nadolski@intel.com \
--cc=hch@lst.de \
--cc=ingo_brunberg@web.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).