From: Hans de Goede <hdegoede@redhat.com>
To: Maxim Mikityanskiy <maxtram95@gmail.com>
Cc: "Mark Gross" <markgross@kernel.org>,
"Andy Shevchenko" <andy@kernel.org>,
"Barnabás Pőcze" <pobrn@protonmail.com>,
"Kai Heng Feng" <kai.heng.feng@canonical.com>,
"GOESSEL Guillaume" <g_goessel@outlook.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Manyi Li" <limanyi@uniontech.com>,
"Eray Orçunus" <erayorcunus@gmail.com>,
"Philipp Jungkamp" <p.jungkamp@gmx.net>,
"Arnav Rawat" <arnavr3@illinois.edu>,
"Kelly Anderson" <kelly@xilka.com>,
"Meng Dong" <whenov@gmail.com>,
"Felix Eckhofer" <felix@eckhofer.com>,
"Ike Panhc" <ike.pan@canonical.com>,
platform-driver-x86@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] platform/x86: ideapad-laptop: Stop sending KEY_TOUCHPAD_TOGGLE
Date: Tue, 4 Apr 2023 09:56:59 +0200 [thread overview]
Message-ID: <7cd9a667-9ec8-b0a9-6f2c-de5f961d765b@redhat.com> (raw)
In-Reply-To: <ZCs8SA47vGCjVl1l@mail.gmail.com>
Hi,
On 4/3/23 22:51, Maxim Mikityanskiy wrote:
> On Fri, 31 Mar 2023 at 12:51:30 +0300, Maxim Mikityanskiy wrote:
>> On Thu, 30 Mar 2023 at 21:46:44 +0200, Hans de Goede wrote:
>>> Commit 5829f8a897e4 ("platform/x86: ideapad-laptop: Send
>>> KEY_TOUCHPAD_TOGGLE on some models") made ideapad-laptop send
>>> KEY_TOUCHPAD_TOGGLE when we receive an ACPI notify with VPC event bit 5 set
>>> and the touchpad-state has not been changed by the EC itself already.
>>>
>>> This was done under the assumption that this would be good to do to make
>>> the touchpad-toggle hotkey work on newer models where the EC does not
>>> toggle the touchpad on/off itself (because it is not routed through
>>> the PS/2 controller, but uses I2C).
>>>
>>> But it turns out that at least some models, e.g. the Yoga 7-15ITL5 the EC
>>> triggers an ACPI notify with VPC event bit 5 set on resume, which would
>>> now cause a spurious KEY_TOUCHPAD_TOGGLE on resume to which the desktop
>>> environment responds by disabling the touchpad in software, breaking
>>> the touchpad (until manually re-enabled) on resume.
>>
>> Oh gosh, the touchpad toggle on Ideapads is so much broken, I wonder how
>> the Windows driver deals with all this variety of different behaviors
>> (unless it's broken too :D).
>>
>> I'll test the patch on Z570, but as I see, it shouldn't change anything
>> for Z570.
>
> Tested the kernel from your branch on Z570, the touchpad button still
> works fine.
Thank you for testing.
Regards,
Hans
next prev parent reply other threads:[~2023-04-04 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 19:46 [PATCH] platform/x86: ideapad-laptop: Stop sending KEY_TOUCHPAD_TOGGLE Hans de Goede
2023-03-31 9:51 ` Maxim Mikityanskiy
2023-04-03 20:51 ` Maxim Mikityanskiy
2023-04-04 7:56 ` Hans de Goede [this message]
2023-03-31 17:38 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cd9a667-9ec8-b0a9-6f2c-de5f961d765b@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@kernel.org \
--cc=arnavr3@illinois.edu \
--cc=erayorcunus@gmail.com \
--cc=felix@eckhofer.com \
--cc=g_goessel@outlook.com \
--cc=ike.pan@canonical.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kai.heng.feng@canonical.com \
--cc=kelly@xilka.com \
--cc=limanyi@uniontech.com \
--cc=markgross@kernel.org \
--cc=maxtram95@gmail.com \
--cc=p.jungkamp@gmx.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=stable@vger.kernel.org \
--cc=whenov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).