From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35FFAC433DB for ; Wed, 17 Mar 2021 14:00:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D874C64F5E for ; Wed, 17 Mar 2021 14:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231617AbhCQN7m (ORCPT ); Wed, 17 Mar 2021 09:59:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:48260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231470AbhCQN7j (ORCPT ); Wed, 17 Mar 2021 09:59:39 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FB3C64F5E; Wed, 17 Mar 2021 13:59:39 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lMWi1-002Deb-4X; Wed, 17 Mar 2021 13:59:37 +0000 Date: Wed, 17 Mar 2021 13:59:36 +0000 Message-ID: <87eegdj2yf.wl-maz@kernel.org> From: Marc Zyngier To: Suzuki K Poulose Cc: stable@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, alexandru.elisei@arm.com, christoffer.dall@arm.com Subject: Re: [PATCH] KVM: arm64: nvhe: Save the SPE context early In-Reply-To: <20210316183353.4081445-1-suzuki.poulose@arm.com> References: <16157981451454@kroah.com> <20210316183353.4081445-1-suzuki.poulose@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: suzuki.poulose@arm.com, stable@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, alexandru.elisei@arm.com, christoffer.dall@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, 16 Mar 2021 18:33:53 +0000, Suzuki K Poulose wrote: > > commit b96b0c5de685df82019e16826a282d53d86d112c upstream > > The nVHE KVM hyp drains and disables the SPE buffer, before > entering the guest, as the EL1&0 translation regime > is going to be loaded with that of the guest. > > But this operation is performed way too late, because : > - The owning translation regime of the SPE buffer > is transferred to EL2. (MDCR_EL2_E2PB == 0) > - The guest Stage1 is loaded. > > Thus the flush could use the host EL1 virtual address, > but use the EL2 translations instead of host EL1, for writing > out any cached data. > > Fix this by moving the SPE buffer handling early enough. > The restore path is doing the right thing. > > Cc: stable@vger.kernel.org # v5.4- > Cc: Christoffer Dall > Cc: Marc Zyngier > Cc: Will Deacon > Cc: Catalin Marinas > Cc: Mark Rutland > Cc: Alexandru Elisei > Signed-off-by: Suzuki K Poulose Acked-by: Marc Zyngier Thanks, M. -- Without deviation from the norm, progress is not possible.