From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 530E4C34049 for ; Tue, 18 Feb 2020 18:54:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D60D24125 for ; Tue, 18 Feb 2020 18:54:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582052042; bh=8iTTgbNMqPWasH5TX/yI/YgmsPPCAjZU28vIghYMb6o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=L3c66177g/PlvBD/LjKnabZsy3zte7ZDYASURF1gGIFSoY3L6JZIcpJ6F5ybIFptu dASMoQxb7lvIUc3dTMaap8+o6nnQerRI1/Jg/wx9VNxNG/0zZT2E5rDZjQA70KnKuJ RMry9PBRE8Ciys895Wh6T2WQatcW/Vc/ufthd74I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbgBRSyB (ORCPT ); Tue, 18 Feb 2020 13:54:01 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:45052 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbgBRSyB (ORCPT ); Tue, 18 Feb 2020 13:54:01 -0500 Received: by mail-lj1-f193.google.com with SMTP id q8so24156074ljj.11 for ; Tue, 18 Feb 2020 10:53:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gInmCZBr53UYRN/0yNo3xgcN+xMMFqgmTLh6dxUQ8E4=; b=QlbEHSRfkbu7KS+THYfLYq63FliUeh77hmRjUROQFp94gIFTzMuzUhxH0VcrEPWC37 yJf+X25qCjCpYArPLbxLXcRp42Pd1jfikvfZEA2NJnIKHwC5rNGfxmsKVeUYcU314FvM 7tU+JcTTL1VwCcjNBZZ3j3BM0KB+XtlR77//4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gInmCZBr53UYRN/0yNo3xgcN+xMMFqgmTLh6dxUQ8E4=; b=TzFZx3FFFMSGaAmPVuHd5pb5VoIRX/m7tNdyrLEaJ+e84VgWJPUQIlLFl4oQ0c6I3Q qX43lvm+7Ee2AwyYPMqcubnKXyJNsPoYNE/YAk9mOSrfKq10QdT0Hw74HF7Q4b81rR5b QIz3dgIhEim/WgPOgVYJzOQufbFpInOP/LUm9yt/0FiIj+CnBHSIBSQtLOPjyJv3WYNi rdLImU/hkUG4Snn+tWr/qO51061IE9s8hnSLX8XSGrddrk4XVm9zkfcyYvwHMQwNO4i5 fkcgvqfg2eEo0JyRRRDz/3VRYLSklkEVBbE4cwoya6E9Jbs2RwpNuFkZT5OExYdeJahc ZKXA== X-Gm-Message-State: APjAAAUGreo/01Lohb4qik45xNduxZFvgfLhBljo7lQYp/e9947hxAs7 TraQDk/lm4ccZWTdfSyNCjtVlNeB4K8= X-Google-Smtp-Source: APXvYqxgnfosiqKc4EOPkJRzLQgOGp4/eP50KreB64ZgoUJcsezW/v9XbP8mDhoY/zq0K+7IDUr+sQ== X-Received: by 2002:a2e:89cd:: with SMTP id c13mr13392144ljk.139.1582052038727; Tue, 18 Feb 2020 10:53:58 -0800 (PST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com. [209.85.167.48]) by smtp.gmail.com with ESMTPSA id t27sm3028696ljd.26.2020.02.18.10.53.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Feb 2020 10:53:57 -0800 (PST) Received: by mail-lf1-f48.google.com with SMTP id r14so15296418lfm.5 for ; Tue, 18 Feb 2020 10:53:57 -0800 (PST) X-Received: by 2002:ac2:456f:: with SMTP id k15mr11156468lfm.125.1582052037344; Tue, 18 Feb 2020 10:53:57 -0800 (PST) MIME-Version: 1.0 References: <20200214154854.6746-1-sashal@kernel.org> <20200214154854.6746-542-sashal@kernel.org> In-Reply-To: <20200214154854.6746-542-sashal@kernel.org> From: Linus Torvalds Date: Tue, 18 Feb 2020 10:53:41 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH AUTOSEL 5.5 542/542] pipe: use exclusive waits when reading or writing To: Sasha Levin Cc: Linux Kernel Mailing List , stable , Josh Triplett , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Feb 14, 2020 at 8:00 AM Sasha Levin wrote: > > From: Linus Torvalds > > [ Upstream commit 0ddad21d3e99c743a3aa473121dc5561679e26bb ] > > This makes the pipe code use separate wait-queues and exclusive waiting > for readers and writers, [..] Oh, and since I didn't react initially, let me react now that Andrei found a bug here: why was this patch auto-selected for 5.5 stable in the first place? It wasn't really a fix, and there's no Fixes: tag or stable tag in there. Yeah, there's a reference to an old commit, but that one isn't even a kernel commit. Yeah, the performance improvements are quite nice if you hit the case this matters for, but still.. Linus