From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Sasha Levin <sashal@kernel.org>,
linux-stable <stable@vger.kernel.org>,
lkft-triage@lists.linaro.org,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@linux.ie>,
kieran.bingham+renesas@ideasonboard.com
Subject: Re: rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type
Date: Mon, 1 Mar 2021 19:52:09 +0100 [thread overview]
Message-ID: <YD032bZZ/y2Mh0ab@kroah.com> (raw)
In-Reply-To: <CA+G9fYvApAT=vx_XxhbMZ=rS8ShhYkSKa0JsHC8k0dFn5xwU=Q@mail.gmail.com>
On Mon, Mar 01, 2021 at 11:11:26PM +0530, Naresh Kamboju wrote:
> On stable rc 5.11 the x86_64 build failed due to below errors/warnings.
>
> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup':
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit
> declaration of function 'to_rcar_du_device'; did you mean
> 'to_rtc_device'? [-Werror=implicit-function-declaration]
> struct rcar_du_device *rcdu = to_rcar_du_device(dev);
> ^~~~~~~~~~~~~~~~~
> to_rtc_device
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization
> makes pointer from integer without a cast [-Wint-conversion]
> In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0:
> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init':
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument
> 1 of '__drmm_add_action' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL);
> ^
> include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action'
> __drmm_add_action(dev, action, data, #action)
> ^~~
> include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *'
> but argument is of type 'struct drm_device **'
> int __must_check __drmm_add_action(struct drm_device *dev,
> ^~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Very odd, my builds here didn't trigger that, sorry. I'll go drop the
offending patch...
greg k-h
next prev parent reply other threads:[~2021-03-01 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 17:41 rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type Naresh Kamboju
2021-03-01 17:47 ` Naresh Kamboju
2021-03-01 18:52 ` Greg Kroah-Hartman [this message]
2021-03-01 19:59 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD032bZZ/y2Mh0ab@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).