From: Greg KH <greg@kroah.com>
To: Colin Xu <colin.xu@intel.com>
Cc: stable@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org,
zhenyuw@linux.intel.com
Subject: Re: [PATCH 3/5] drm/i915/gvt: Fix virtual display setup for BXT/APL
Date: Fri, 19 Mar 2021 10:40:35 +0100 [thread overview]
Message-ID: <YFRxk6crsi9DaIHB@kroah.com> (raw)
In-Reply-To: <YFRxUpzFf/qAyMER@kroah.com>
On Fri, Mar 19, 2021 at 10:39:30AM +0100, Greg KH wrote:
> On Wed, Mar 17, 2021 at 10:55:02AM +0800, Colin Xu wrote:
> > commit a5a8ef937cfa79167f4b2a5602092b8d14fd6b9a upstream
> >
> > Program display related vregs to proper value at initialization, setup
> > virtual monitor and hotplug.
> >
> > vGPU virtual display vregs inherit the value from pregs. The virtual DP
> > monitor is always setup on PORT_B for BXT/APL. However the host may
> > connect monitor on other PORT or without any monitor connected. Without
> > properly setup PIPE/DDI/PLL related vregs, guest driver may not setup
> > the virutal display as expected, and the guest desktop may not be
> > created.
> > Since only one virtual display is supported, enable PIPE_A only. And
> > enable transcoder/DDI/PLL based on which port is setup for BXT/APL.
> >
> > V2:
> > Revise commit message.
> >
> > V3:
> > set_edid should on PORT_B for BXT.
> > Inject hpd event for BXT.
> >
> > V4:
> > Temporarily disable vfio edid on BXT/APL until issue fixed.
> >
> > V5:
> > Rebase to use new HPD define GEN8_DE_PORT_HOTPLUG for BXT.
> > Put vfio edid disabling on BXT/APL to a separate patch.
> >
> > Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> > Signed-off-by: Colin Xu <colin.xu@intel.com>
> > Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> > Link: http://patchwork.freedesktop.org/patch/msgid/20201109073922.757759-1-colin.xu@intel.com
> > (cherry picked from commit a5a8ef937cfa79167f4b2a5602092b8d14fd6b9a)
> > Signed-off-by: Colin Xu <colin.xu@intel.com>
> > Cc: <stable@vger.kernel.org> # 5.4.y
> > ---
> > drivers/gpu/drm/i915/gvt/display.c | 173 +++++++++++++++++++++++++++++
> > drivers/gpu/drm/i915/gvt/mmio.c | 5 +
> > 2 files changed, 178 insertions(+)
>
> I've taken this backport for 5.10.y as well, because it is missing
> there.
Oops, nope, it breaks the build.
Please also provide a working backport for this as well, we can not have
users moving to a newer kernel version and have a regression for a known
issue.
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-19 9:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 2:54 [PATCH 0/5] drm/i915/gvt: Backport GVT BXT/APL fix to 5.4.y Colin Xu
2021-03-17 2:55 ` [PATCH 1/5] drm/i915/gvt: Set SNOOP for PAT3 on BXT/APL to workaround GPU BB hang Colin Xu
2021-03-17 2:55 ` [PATCH 2/5] drm/i915/gvt: Fix mmio handler break on BXT/APL Colin Xu
2021-03-17 2:55 ` [PATCH 3/5] drm/i915/gvt: Fix virtual display setup for BXT/APL Colin Xu
2021-03-19 9:39 ` Greg KH
2021-03-19 9:40 ` Greg KH [this message]
2021-03-17 2:55 ` [PATCH 4/5] drm/i915/gvt: Fix port number for BDW on EDID region setup Colin Xu
2021-03-17 2:55 ` [PATCH 5/5] drm/i915/gvt: Fix vfio_edid issue for BXT/APL Colin Xu
2021-03-19 9:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFRxk6crsi9DaIHB@kroah.com \
--to=greg@kroah.com \
--cc=colin.xu@intel.com \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).