From: Greg KH <gregkh@linuxfoundation.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: stable@vger.kernel.org, Thomas Wagner <thwa1@web.de>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [BACKPORT stable Linux-5.10.y 2/2] can: isotp: add SF_BROADCAST support for functional addressing
Date: Thu, 17 Feb 2022 19:58:30 +0100 [thread overview]
Message-ID: <Yg6a1uJGpZoOSewT@kroah.com> (raw)
In-Reply-To: <20220216063137.2023-2-socketcan@hartkopp.net>
On Wed, Feb 16, 2022 at 07:31:37AM +0100, Oliver Hartkopp wrote:
> Upstream commit 921ca574cd382142add8b12d0a7117f495510de5
>
> The patch was intended for 5.10 but missed the merge window by some days.
> This missing patch continously breaks the backport of stable fixes and is
> the only missing feature of upstream isotp in Linux 5.10 e.g. for RasPi.
>
> When CAN_ISOTP_SF_BROADCAST is set in the CAN_ISOTP_OPTS flags the CAN_ISOTP
> socket is switched into functional addressing mode, where only single frame
> (SF) protocol data units can be send on the specified CAN interface and the
> given tp.tx_id after bind().
>
> In opposite to normal and extended addressing this socket does not register a
> CAN-ID for reception which would be needed for a 1-to-1 ISOTP connection with a
> segmented bi-directional data transfer.
>
> Sending SFs on this socket is therefore a TX-only 'broadcast' operation.
>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> Signed-off-by: Thomas Wagner <thwa1@web.de>
> Link: https://lore.kernel.org/r/20201206144731.4609-1-socketcan@hartkopp.net
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> include/uapi/linux/can/isotp.h | 2 +-
> net/can/isotp.c | 50 ++++++++++++++++++++++++----------
> 2 files changed, 37 insertions(+), 15 deletions(-)
Both now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-02-17 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 6:31 [BACKPORT stable Linux-5.10.y 1/2] can: isotp: prevent race between isotp_bind() and isotp_setsockopt() Oliver Hartkopp
2022-02-16 6:31 ` [BACKPORT stable Linux-5.10.y 2/2] can: isotp: add SF_BROADCAST support for functional addressing Oliver Hartkopp
2022-02-17 18:58 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg6a1uJGpZoOSewT@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
--cc=stable@vger.kernel.org \
--cc=thwa1@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).