stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: daniel@iogearbox.net
Cc: andrii@kernel.org, ast@kernel.org, stable@vger.kernel.org,
	Greg KH <gregkh@linuxfoundation.org>
Subject: Re: FAILED: patch "[PATCH] bpf: Fix toctou on read-only map's constant scalar tracking" failed to apply to 5.4-stable tree
Date: Mon, 21 Feb 2022 10:44:35 +0000	[thread overview]
Message-ID: <YhNtE/sIdv5OkBQT@google.com> (raw)
In-Reply-To: <YhNoZy415MYPH+GR@kroah.com>

On Mon, 21 Feb 2022, Greg KH wrote:

> On Mon, Feb 21, 2022 at 09:52:34AM +0000, Lee Jones wrote:
> > On Thu, 17 Feb 2022, Lee Jones wrote:
> > 
> > > On Thu, 17 Feb 2022, Greg KH wrote:
> > > 
> > > > On Thu, Feb 17, 2022 at 03:57:23PM +0000, Lee Jones wrote:
> > > > > Good afternoon Daniel,
> > > > > 
> > > > > On Mon, 22 Nov 2021, gregkh@linuxfoundation.org wrote:
> > > > > > 
> > > > > > The patch below does not apply to the 5.4-stable tree.
> > > > > > If someone wants it applied there, or to any other stable or longterm
> > > > > > tree, then please email the backport, including the original git commit
> > > > > > id to <stable@vger.kernel.org>.
> > > > > 
> > > > > We are in receipt of a bug report which cites this patch as the fix.
> > > > 
> > > > Does the bug report really say that this issue is present in the 5.4
> > > > kernel tree?  Anything older?
> > > 
> > > Not specifically, but the commit referenced in the Fixes tag landed in
> > > v5.5. and was successfully back-ported to v5.4.144.
> > 
> > Another potential avenue might to be revert the back-ported commit
> > which caused the issue from v5.4.y.
> 
> Unless that was fixing a different issue?  I have no idea at this point
> what commit you are talking about, sorry :(

The bad-commit mentioned in "the Fixes tag":

Fixes: a23740ec43ba ("bpf: Track contents of read-only maps as scalars")

Which as you say, could well have been fixing another issue.

In fact, yes it was:

https://lore.kernel.org/stable/20210821203108.215937-2-rafaeldtinoco@gmail.com/

Daniel, what do you suggest please?

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2022-02-21 11:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 10:33 FAILED: patch "[PATCH] bpf: Fix toctou on read-only map's constant scalar tracking" failed to apply to 5.4-stable tree gregkh
2022-02-17 15:57 ` Lee Jones
2022-02-17 16:17   ` Greg KH
2022-02-17 17:05     ` Lee Jones
2022-02-21  9:52       ` Lee Jones
2022-02-21 10:24         ` Greg KH
2022-02-21 10:44           ` Lee Jones [this message]
2022-03-01 21:23             ` Daniel Borkmann
2022-03-01 22:04               ` Rafael David Tinoco
2022-03-05 13:50                 ` Greg KH
2022-03-07  8:38                   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhNtE/sIdv5OkBQT@google.com \
    --to=lee.jones@linaro.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).