From: Peter Hutterer <peter.hutterer@who-t.net>
To: "José Expósito" <jose.exposito89@gmail.com>
Cc: jkosina@suse.cz, tiwai@suse.de, benjamin.tissoires@redhat.com,
regressions@leemhuis.info, linux-input@vger.kernel.org,
stable@vger.kernel.org, regressions@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads"
Date: Wed, 23 Mar 2022 15:05:37 +1000 [thread overview]
Message-ID: <YjqqoW9jU3SoBgYn@quokka> (raw)
In-Reply-To: <20220321184404.20025-1-jose.exposito89@gmail.com>
On Mon, Mar 21, 2022 at 07:44:05PM +0100, José Expósito wrote:
> This reverts commit 37ef4c19b4c659926ce65a7ac709ceaefb211c40.
>
> The touchpad present in the Dell Precision 7550 and 7750 laptops
> reports a HID_DG_BUTTONTYPE of type MT_BUTTONTYPE_CLICKPAD. However,
> the device is not a clickpad, it is a touchpad with physical buttons.
>
> In order to fix this issue, a quirk for the device was introduced in
> libinput [1] [2] to disable the INPUT_PROP_BUTTONPAD property:
>
> [Precision 7x50 Touchpad]
> MatchBus=i2c
> MatchUdevType=touchpad
> MatchDMIModalias=dmi:*svnDellInc.:pnPrecision7?50*
> AttrInputPropDisable=INPUT_PROP_BUTTONPAD
>
> However, because of the change introduced in 37ef4c19b4 ("Input: clear
> BTN_RIGHT/MIDDLE on buttonpads") the BTN_RIGHT key bit is not mapped
> anymore breaking the device right click button and making impossible to
> workaround it in user space.
>
> In order to avoid breakage on other present or future devices, revert
> the patch causing the issue.
>
> Cc: stable@vger.kernel.org
> Link: https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/481 [1]
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=1868789 [2]
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
Cheers,
Peter
> ---
> drivers/input/input.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index c3139bc2aa0d..ccaeb2426385 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -2285,12 +2285,6 @@ int input_register_device(struct input_dev *dev)
> /* KEY_RESERVED is not supposed to be transmitted to userspace. */
> __clear_bit(KEY_RESERVED, dev->keybit);
>
> - /* Buttonpads should not map BTN_RIGHT and/or BTN_MIDDLE. */
> - if (test_bit(INPUT_PROP_BUTTONPAD, dev->propbit)) {
> - __clear_bit(BTN_RIGHT, dev->keybit);
> - __clear_bit(BTN_MIDDLE, dev->keybit);
> - }
> -
> /* Make sure that bitmasks not mentioned in dev->evbit are clean. */
> input_cleanse_bitmasks(dev);
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-03-23 5:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 18:44 [PATCH] Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads" José Expósito
2022-03-22 11:15 ` Hans de Goede
2022-03-23 5:05 ` Peter Hutterer [this message]
2022-03-30 12:27 ` Thorsten Leemhuis
2022-03-30 12:30 ` Benjamin Tissoires
2022-03-31 4:13 ` Dmitry Torokhov
2022-03-31 4:38 ` Peter Hutterer
2022-04-01 4:23 ` Dmitry Torokhov
2022-04-05 9:35 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjqqoW9jU3SoBgYn@quokka \
--to=peter.hutterer@who-t.net \
--cc=benjamin.tissoires@redhat.com \
--cc=jkosina@suse.cz \
--cc=jose.exposito89@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).