From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3768C433F5 for ; Wed, 6 Apr 2022 15:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235484AbiDFPNM (ORCPT ); Wed, 6 Apr 2022 11:13:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235841AbiDFPMe (ORCPT ); Wed, 6 Apr 2022 11:12:34 -0400 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FB4422836B for ; Wed, 6 Apr 2022 05:13:08 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 5CF873200EAD; Wed, 6 Apr 2022 08:12:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 06 Apr 2022 08:12:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=HICJqCIevJNs7C HtYoFBzAhRihzeEnaBSA45TAE/+is=; b=Q3YEoUYN598IgecT4CJlWcoNBqSR/Q wScunIG1EAxENJKGI5/WrI1TGeeA8bJhkfB50R7295hZhOCORieqfzIHnM3OlTpm ShviakAdFpv+K4SAYXWwrjGmagJ059iKW55TUeVFH6QKCy6gikd7+VD9VTBT8GKR TulBSevEahzZpzcR64g4YYHYPAkWn5ZRv5vVgFWqO3Wg0/APDtT1oc/s/xQPKwzw qMCZQglDVG+NInAxpfkm9SJBssx1WfCuUIL22EW/LjFWB56cgELeCdARykRjy2n2 hz72aN7OibnAvbJsL+cB5RD3HizeV7leabI55DqaVlBQZo6BOaiLvZsQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=HICJqCIevJNs7CHtYoFBzAhRihzeEnaBSA45TAE/+ is=; b=bwvNOWPriSLJWWfM0W9vbrP/6eGL/p4DDWSg10M8dPnVwB3KeBEX8oMw8 o1edReKsOdGdZD6GSSp0ZPVFVjNjJBmNB2fYVlWLajdNmiB94qjaOOosU8QBLdbi nJz7TYVs208lIG7XIfMbGEmD0ITzx/bZZ1mClql5zVBdJHKAqeTUWoda1Y3gHyjJ 4d3pGbubcYOBmQW4tmwqDJ8k/aSHZu2WfktQnZFsaDiplcbmtphfroCF8QGdLZ+u PYPcpDgz/IpJ/gSjnEoTphO676lvuOw7o0yU1pZGCAZaTjkqXwe/1UOkkNibuZya 82nlDquOgg7/nU1ZhwTlhXOlTcntQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejiedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepgeeije euvdffuedvffdtteefuefhkeehgfeuffejveettdelgfeuudffffetfedtnecuffhomhgr ihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Apr 2022 08:12:30 -0400 (EDT) Date: Wed, 6 Apr 2022 14:12:27 +0200 From: Greg KH To: dann frazier Cc: Marc Zyngier , Lorenzo Pieralisi , stable@vger.kernel.org, Rob Herring , Toan Le , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , =?iso-8859-1?Q?St=E9phane?= Graber Subject: Re: [PATCH v5.10] PCI: xgene: Revert "PCI: xgene: Use inbound resources for setup" Message-ID: References: <20220405153419.1330755-1-dann.frazier@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220405153419.1330755-1-dann.frazier@canonical.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 05, 2022 at 09:34:19AM -0600, dann frazier wrote: > From: Marc Zyngier > > commit 1874b6d7ab1bdc900e8398026350313ac29caddb upstream. > > Commit 6dce5aa59e0b ("PCI: xgene: Use inbound resources for setup") > killed PCIe on my XGene-1 box (a Mustang board). The machine itself > is still alive, but half of its storage (over NVMe) is gone, and the > NVMe driver just times out. > > Note that this machine boots with a device tree provided by the > UEFI firmware (2016 vintage), which could well be non conformant > with the spec, hence the breakage. > > With the patch reverted, the box boots 5.17-rc8 with flying colors. > > Link: https://lore.kernel.org/all/Yf2wTLjmcRj+AbDv@xps13.dannf > Link: https://lore.kernel.org/r/20220321104843.949645-2-maz@kernel.org > Fixes: 6dce5aa59e0b ("PCI: xgene: Use inbound resources for setup") > Signed-off-by: Marc Zyngier > Signed-off-by: Lorenzo Pieralisi > Cc: stable@vger.kernel.org > Cc: Rob Herring > Cc: Toan Le > Cc: Lorenzo Pieralisi > Cc: Krzysztof Wilczyński > Cc: Bjorn Helgaas > Cc: Stéphane Graber > Cc: dann frazier > [dannf: minor context adjustment] > Signed-off-by: dann frazier > --- > drivers/pci/controller/pci-xgene.c | 33 ++++++++++++++++++++---------- > 1 file changed, 22 insertions(+), 11 deletions(-) All now queued up, thanks. greg k-h