From: Johan Hovold <johan@kernel.org>
To: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
Cc: Doug Anderson <dianders@chromium.org>,
Johan Hovold <johan+linaro@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
quic_mohamull@quicinc.com, quic_hbandi@quicinc.com
Subject: Re: [PATCH] Bluetooth: qca: fix invalid device address check
Date: Fri, 26 Apr 2024 16:15:47 +0200 [thread overview]
Message-ID: <Ziu3E5hD7L8CAn-1@hovoldconsulting.com> (raw)
In-Reply-To: <Ziuh5qO94076gT2G@hovoldconsulting.com>
On Fri, Apr 26, 2024 at 02:45:26PM +0200, Johan Hovold wrote:
> On Fri, Apr 26, 2024 at 04:12:07PM +0530, Janaki Ramaiah Thota wrote:
> > On 4/26/2024 11:53 AM, Janaki Ramaiah Thota wrote:
> > > On 4/25/2024 9:28 PM, Johan Hovold wrote:
> > >>> ---------------------------------------------------------
> > >>> | BDA | Chipset |
> > >>> ---------------------------------------------------------
> > >>> | 20 00 00 10 80 39 | WCN3988 with ROM Version 0x0200 |
> > >>> ---------------------------------------------------------
> > >>> | 00 08 74 12 80 39 | WCN3988 with ROM Version 0x0201 |
> > >>> ---------------------------------------------------------
> > >>> | 00 07 64 21 90 39 | WCN3990 |
> > >>> ---------------------------------------------------------
> > >>
> > >> Thanks a lot for these. I see now that the default Trogdor address Doug
> > >> reported (39:98:00:00:5a:ad) appears to comes from the fw too:
> > >>
> > >> $ od -x crnv32.bin | grep 5aad
> > >>
> > >> 0000020 0000 0000 5aad 0000 3998 0008 0008 0000
I took a closer look at the configuration file format and it seems we
can just fetch the default address from the file. The driver is already
parsing it so this should be straight forward.
I'll cook up a patch.
Johan
next prev parent reply other threads:[~2024-04-26 14:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 9:15 [PATCH] Bluetooth: qca: fix invalid device address check Johan Hovold
2024-04-16 15:10 ` patchwork-bot+bluetooth
2024-04-22 17:50 ` Doug Anderson
2024-04-23 9:08 ` Johan Hovold
2024-04-23 15:09 ` Doug Anderson
2024-04-25 8:40 ` Johan Hovold
2024-04-25 15:01 ` Janaki Ramaiah Thota
2024-04-25 15:58 ` Johan Hovold
2024-04-26 6:23 ` Janaki Ramaiah Thota
2024-04-26 10:42 ` Janaki Ramaiah Thota
2024-04-26 12:45 ` Johan Hovold
2024-04-26 14:15 ` Johan Hovold [this message]
2024-04-25 15:22 ` Doug Anderson
2024-04-25 16:13 ` Johan Hovold
2024-04-25 16:19 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ziu3E5hD7L8CAn-1@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=dianders@chromium.org \
--cc=johan+linaro@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=quic_hbandi@quicinc.com \
--cc=quic_janathot@quicinc.com \
--cc=quic_mohamull@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).