From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"romain.izard.pro@gmail.com" <romain.izard.pro@gmail.com>
Subject: Re: [PATCH 1/2] usb: gadget: f_ncm: Add OS descriptor support
Date: Sun, 18 Jun 2023 09:58:14 +0000 [thread overview]
Message-ID: <afbf34e128a744bb37f8e533248b69c2b0fdff9e.camel@infinera.com> (raw)
In-Reply-To: <2023061854-daydream-outage-de91@gregkh>
On Sun, 2023-06-18 at 09:36 +0200, Greg KH wrote:
> On Sat, Jun 17, 2023 at 04:03:06PM +0000, Joakim Tjernlund wrote:
> > Ping ?
> >
> > Did I do something wrong with submission or is it queued for later ?
> > 4.19 is missing these which make USB NCM unusable with Win >= 10.
> >
> > Jocke
> >
> > On Wed, 2023-05-31 at 19:33 +0200, Joakim Tjernlund wrote:
> > > From: Romain Izard <romain.izard.pro@gmail.com>
> > >
> > > To be able to use the default USB class drivers available in Microsoft
> > > Windows, we need to add OS descriptors to the exported USB gadget to
> > > tell the OS that we are compatible with the built-in drivers.
> > >
> > > Copy the OS descriptor support from f_rndis into f_ncm. As a result,
> > > using the WINNCM compatible ID, the UsbNcm driver is loaded on
> > > enumeration without the need for a custom driver or inf file.
> > >
> > > Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> > > Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> > > Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> > > Cc: stable@vger.kernel.org # v4.19
> > > ---
> > >
> > > Seems to have been forgotten when backporting NCM fixes.
> > > Needed to make Win10 accept Linux NCM gadget ethernet
> > >
> > > drivers/usb/gadget/function/f_ncm.c | 47 +++++++++++++++++++++++++++--
> > > drivers/usb/gadget/function/u_ncm.h | 3 ++
> > > 2 files changed, 47 insertions(+), 3 deletions(-)
>
> What is the git commit id of this change in Linus's tree?
>
> thanks,
>
> greg k-h
For this patch:
793409292382027226769d0299987f06cbd97a6e
and for "usb: gadget: f_ncm: Fix NTP-32 support"
550eef0c353030ac4223b9c9479bdf77a05445d6
Thanks
Jocke
next prev parent reply other threads:[~2023-06-18 9:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 17:33 [PATCH 1/2] usb: gadget: f_ncm: Add OS descriptor support Joakim Tjernlund
2023-06-17 16:03 ` Joakim Tjernlund
2023-06-18 7:36 ` Greg KH
2023-06-18 9:58 ` Joakim Tjernlund [this message]
2023-06-18 11:04 ` gregkh
2023-06-18 11:40 ` [PATCHv2 " Joakim Tjernlund
2023-06-18 11:40 ` [PATCHv2 2/2] usb: gadget: f_ncm: Fix NTP-32 support Joakim Tjernlund
2023-06-18 11:42 ` [PATCH 1/2] usb: gadget: f_ncm: Add OS descriptor support Joakim Tjernlund
2023-06-18 12:55 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afbf34e128a744bb37f8e533248b69c2b0fdff9e.camel@infinera.com \
--to=joakim.tjernlund@infinera.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=romain.izard.pro@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).