stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Burgener <dburgener@linux.microsoft.com>
To: Sasha Levin <sashal@kernel.org>, Paul Moore <paul@paul-moore.com>
Cc: Greg KH <greg@kroah.com>,
	stable@vger.kernel.org,
	Stephen Smalley <stephen.smalley.work@gmail.com>,
	selinux@vger.kernel.org, James Morris <jmorris@namei.org>
Subject: Re: [PATCH v5.4 0/3] Update SELinuxfs out of tree and then swapover
Date: Fri, 16 Oct 2020 10:36:55 -0400	[thread overview]
Message-ID: <b6e32678-ce2e-733d-5de1-dc7f2c00111c@linux.microsoft.com> (raw)
In-Reply-To: <20201016142213.GV2415204@sasha-vm>

On 10/16/20 10:22 AM, Sasha Levin wrote:
> On Fri, Oct 16, 2020 at 09:55:25AM -0400, Paul Moore wrote:
>> On Fri, Oct 16, 2020 at 9:05 AM Daniel Burgener
>> <dburgener@linux.microsoft.com> wrote:
>>> Yes, thank you.  I will fix up the series with the third commit
>>> included, and add commit ids.  Thanks.
>>
>> Greg and I have different opinions on what is classified as a good
>> candidate for the -stable trees, but in my opinion this patch series
>> doesn't qualify.  There are a lot of dependencies, it is intertwined
>> with a lot of code, and the issue that this patchset fixes has been
>> around for a *long* time.  I personally feel the risk of backporting
>> this to -stable does not outweigh the potential wins.
>
> My understanding is that while the issue Daniel is fixing here has been
> around for a while, it's also very real - the reports suggest a failure
> rate of 1-2% on boot.

As a point of clarity, I think that the issue occurs much less 
frequently on boot than it does with a policy load during ordinary 
operation, since there are a much higher volume of userspace policy 
manager lookups on a policy_load once the system is up.  I think 1-2% is 
roughly accurate for what we're seeing in the environment I'm working on 
for a policy load during normal steady state operation.  I don't have 
hard numbers on policy load during boot, but I would expect it to be 
quite a bit lower.  We have seen it, but it's not the common case we're 
seeing.

>
> I do understand your concerns around this series, but given it was just
> fixed upstream we don't have a better story than "sit tight for the
> next LTS" to tell to users affected by this issue.
>
> Is there a scenario where you'd feel safer with the series? I suspect
> that if it doesn't go into upstream stable Daniel will end up carrying
> it out of tree anyway, so maybe we can ask Daniel to do targetted
> testing for the next week or two and report back?
>
I believe my team will intend to carry this out of tree, yes.  If 
additional data from that would be helpful, I'd be happy to provide it.

-Daniel



      reply	other threads:[~2020-10-16 14:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 19:29 [PATCH v5.4 0/3] Update SELinuxfs out of tree and then swapover Daniel Burgener
2020-10-15 19:29 ` [PATCH v5.4 1/3] selinux: Create function for selinuxfs directory cleanup Daniel Burgener
2020-10-16  4:59   ` Greg KH
2020-10-15 19:29 ` [PATCH v5.4 2/3] selinux: Refactor selinuxfs directory populating functions Daniel Burgener
2020-10-15 19:29 ` [PATCH v5.4 3/3] selinux: Create new booleans and class dirs out of tree Daniel Burgener
2020-10-16  1:50   ` Sasha Levin
2020-10-16  5:00 ` [PATCH v5.4 0/3] Update SELinuxfs out of tree and then swapover Greg KH
2020-10-16 13:05   ` Daniel Burgener
2020-10-16 13:55     ` Paul Moore
2020-10-16 14:02       ` Daniel Burgener
2020-10-16 14:22       ` Sasha Levin
2020-10-16 14:36         ` Daniel Burgener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6e32678-ce2e-733d-5de1-dc7f2c00111c@linux.microsoft.com \
    --to=dburgener@linux.microsoft.com \
    --cc=greg@kroah.com \
    --cc=jmorris@namei.org \
    --cc=paul@paul-moore.com \
    --cc=sashal@kernel.org \
    --cc=selinux@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).