stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Safonov <0x7f454c46@gmail.com>
To: Andrei Vagin <avagin@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Darren Hart <dvhart@infradead.org>, Shuah Khan <shuah@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/2] futex: adjust a futex timeout with a per-timens offset
Date: Thu, 15 Oct 2020 14:26:16 +0100	[thread overview]
Message-ID: <fc50656f-2df8-06c9-653a-8d2910949401@gmail.com> (raw)
In-Reply-To: <20201015072909.271426-1-avagin@gmail.com>

On 10/15/20 8:29 AM, Andrei Vagin wrote:
> For all commands except FUTEX_WAIT, timeout is interpreted as an
> absolute value. This absolute value is inside the task's time namespace
> and has to be converted to the host's time.
> 
> Cc: <stable@vger.kernel.org>
> Fixes: 5a590f35add9 ("posix-clocks: Wire up clock_gettime() with timens offsets")
> Reported-by: Hans van der Laan <j.h.vanderlaan@student.utwente.nl>
> Signed-off-by: Andrei Vagin <avagin@gmail.com>[..]
> @@ -3797,6 +3798,8 @@ SYSCALL_DEFINE6(futex, u32 __user *, uaddr, int, op, u32, val,
>  		t = timespec64_to_ktime(ts);
>  		if (cmd == FUTEX_WAIT)
>  			t = ktime_add_safe(ktime_get(), t);
> +		else if (!(cmd & FUTEX_CLOCK_REALTIME))
> +			t = timens_ktime_to_host(CLOCK_MONOTONIC, t);

Err, it probably should be
: else if (!(op & FUTEX_CLOCK_REALTIME))

And there's also
: SYSCALL_DEFINE6(futex_time32, ...)
which wants to be patched.

Thanks,
          Dmitry

  parent reply	other threads:[~2020-10-15 13:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15  7:29 [PATCH 1/2] futex: adjust a futex timeout with a per-timens offset Andrei Vagin
2020-10-15  9:35 ` [tip: timers/urgent] futex: Adjust futex absolute timeouts with " tip-bot2 for Andrei Vagin
2020-10-15 13:26 ` Dmitry Safonov [this message]
2020-10-15 14:13   ` [PATCH 1/2] futex: adjust a futex timeout with a " Thomas Gleixner
2020-10-16  8:18     ` Andrei Vagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc50656f-2df8-06c9-653a-8d2910949401@gmail.com \
    --to=0x7f454c46@gmail.com \
    --cc=avagin@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).