From: "Konstantin Ryabitsev" <konstantin@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: tools@linux.kernel.org
Subject: Re: b4 not finding patches
Date: Wed, 18 Mar 2020 17:07:16 -0400 [thread overview]
Message-ID: <20200318210458.m4vkzhkjw52puodx@chatter.i7.local> (raw)
In-Reply-To: <20200318205914.GG4553@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]
On Wed, Mar 18, 2020 at 08:59:14PM +0000, Mark Brown wrote:
> > > https://lore.kernel.org/alsa-devel/87wo7kolfa.wl-kuninori.morimoto.gx@renesas.com/
>
> > This is because the cover letter is the only bit where we see "v3":
>
> > > [PATCH v3 0/6]
>
> > all other messages have
>
> > > [PATCH N/6]
>
> > I'm not sure if there is a reliably clean way of handling this
> > situation, but I'll think about it. For this particular case, you can
> > just pass -v1 to "b4 am" to grab the actual patches.
>
> ...but not the tags added to the cover letter which is the main reason
> I'm doing this :/ . I do see the issue given people sending new
> serieses in reply to existing ones though. Perhaps some heuristic about
> lack of ambiguity (eg, if we're looking for six patches and find exactly
> six patches)?
This case is probably easier, because it properly threads those patches
below the cover letter. I'll work in some logic to handle cases like
that:
- patches have no explicit version info
- the 00/NN immediately upthread specifies version
in this case we can fairly safely apply the cover letter version info to
all patches.
-K
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 235 bytes --]
next prev parent reply other threads:[~2020-03-18 21:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 20:23 b4 not finding patches Mark Brown
2020-03-18 20:38 ` Konstantin Ryabitsev
2020-03-18 20:59 ` Mark Brown
2020-03-18 21:07 ` Konstantin Ryabitsev [this message]
2020-03-18 22:18 ` Konstantin Ryabitsev
2020-03-20 20:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318210458.m4vkzhkjw52puodx@chatter.i7.local \
--to=konstantin@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).