Re: [MAINTAINER SUMMIT] Rethinking the acceptance policy for "trivial" patches

[Mauro Carvalho Chehab <mchehab@kernel.org>]

Em Thu, 22 Apr 2021 23:46:31 -0700
Joe Perches <joe@perches.com> escreveu:

> On Fri, 2021-04-23 at 08:04 +0200, Mauro Carvalho Chehab wrote:
> > I have a script to automate it, but I had to tweak it while handling
> > patches that cross a single subsystem boundaries, using git send-email
> > with the c/c list obtained from get_maintainers.pl.
> > 
> > By default, the script adds all maintainers, reviewers and all mailing
> > lists to the cover letter, but that sometimes generate a cover letter
> > with 80+ c/c, which will be automatically rejected by anti-spam
> > measures and by mail servers.
> > 
> > So, I played with two different alternatives:
> > 
> > 1. At the beginning, I changed the script to c/c only the mailing lists,
> >    excluding maintainers/reviewers;
> > 2. As the feedback was not great, I changed the script to c/c only
> >    the maintainers, excluding mailing lists/reviewers. It seems that
> >    this worked better.
> > 
> > I didn't try to play with bcc, as replying to it would not send
> > the replies to everyone.
> > 
> > If you think it is worth, I could submit it to scripts/, but I
> > suspect we may need to adjust it to work with all maintainers'
> > workflows.  
> 
> I have a very similar script
> 
> A portion of a cc script I use tests whether cc'ing the cover letter
> to all listed maintainers of a patch series creates a header of less
> than 512 chars and if so cc's all relevant maintainers, otherwise it
> just cc's the mailing lists.
> 
> (Ingo didn't/doesn't want to receive any emails from me)
> 
> $ cat ~/bin/remove_undesirable_emails.sh
> grep -vPi "(?:\bIngo\s+Molnar\b)"
> 
> $ cat ~/bin/cc.sh
> #!/bin/bash
> 
> opts="--nogit --nogit-fallback --norolestats"
> maint_file=$(mktemp -t XXXXXXXX.cc)
> 
> if [[ $(basename $1) =~ ^0000- ]] ; then
>     ./scripts/get_maintainer.pl $opts $(dirname $1)/* |  \
> 	~/bin/remove_undesirable_emails.sh > $maint_file
>     count=$(wc -c $maint_file | cut -f1 -d" ")
>     if [[ $count -lt 512 ]] ; then
> 	cat $maint_file
>     else
> 	./scripts/get_maintainer.pl -nom -nor $opts $(dirname $1)/* | \
> 	    ~/bin/remove_undesirable_emails.sh
>     fi
> 
> ...
> 

Heh, mine is a lot more complex than that ;-) 

It internally runs git format-patch, git send-email and get_maintainers.pl,
and, when --cover or --annotate is used, it opens a window to allow
editing the text. It has several options in order to tweak its behavior. 

That's the result of trying to send a patch series (in this example,
 16 patches for staging/media drivers):

<snip>
$ send-patches.pl upstream/master.. --cover
$ git format-patch -o patches/tmp --stat --summary --patience --signoff --thread=shallow --cover-letter --subject-prefix 'PATCH' upstream/master..
Checking patches/tmp/0000-cover-letter.patch
Checking patches/tmp/0001-media-staging-media-hantro-Align-line-break-to-the-o.patch
./scripts/get_maintainer.pl  patches/tmp/0001-media-staging-media-hantro-Align-line-break-to-the-o.patch
    Cc + cover Cc: Ezequiel Garcia <ezequiel@collabora.com> (maintainer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc + cover Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (maintainer)
    Cc + cover Cc: Philipp Zabel <p.zabel@pengutronix.de> (maintainer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
    Cc + cover Cc: linux-rockchip@lists.infradead.org (open list)
Checking patches/tmp/0002-media-staging-media-hantro-Align-line-break-to-the-o.patch
./scripts/get_maintainer.pl  patches/tmp/0002-media-staging-media-hantro-Align-line-break-to-the-o.patch
    Cc + cover Cc: Ezequiel Garcia <ezequiel@collabora.com> (maintainer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc + cover Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (maintainer)
    Cc + cover Cc: Philipp Zabel <p.zabel@pengutronix.de> (maintainer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
    Cc + cover Cc: linux-rockchip@lists.infradead.org (open list)
Checking patches/tmp/0003-media-staging-media-omap4iss-Align-line-break-to-the.patch
./scripts/get_maintainer.pl  patches/tmp/0003-media-staging-media-omap4iss-Align-line-break-to-the.patch
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc + cover Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (maintainer)
    Cc + cover Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (maintainer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0004-media-staging-media-atomisp-Removed-a-superfluous-el.patch
./scripts/get_maintainer.pl  patches/tmp/0004-media-staging-media-atomisp-Removed-a-superfluous-el.patch
    Cc: Filip Kolev <fil.kolev@gmail.com> (commit_signer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> (commit_signer)
    Cc: Martiros Shakhzadyan <vrzh@vrzh.net> (commit_signer)
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (commit_signer)
    Cc + cover Cc: Sakari Ailus <sakari.ailus@linux.intel.com> (reviewer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0005-media-staging-media-atomisp-i2c-align-line-break-to-.patch
./scripts/get_maintainer.pl  patches/tmp/0005-media-staging-media-atomisp-i2c-align-line-break-to-.patch
    Cc: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com> (commit_signer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> (commit_signer)
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (commit_signer)
    Cc: Sakari Ailus <sakari.ailus@linux.intel.com> (commit_signer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0006-media-staging-media-intel-ipu3-remove-unnecessary-bl.patch
./scripts/get_maintainer.pl  patches/tmp/0006-media-staging-media-intel-ipu3-remove-unnecessary-bl.patch
    Cc + cover Cc: Bingbu Cao <bingbu.cao@intel.com> (reviewer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> (commit_signer)
    Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (commit_signer)
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (commit_signer)
    Cc: Mitali Borkar <mitaliborkar810@gmail.com> (commit_signer)
    Cc: Rahul Gottipati <rahul.blr97@gmail.com> (cc)
    Cc: Sakari Ailus <sakari.ailus@linux.intel.com> (commit_signer)
    Cc + cover Cc: Tianshu Qiu <tian.shu.qiu@intel.com> (reviewer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0007-media-staging-media-intel-ipu3-reduce-length-of-line.patch
./scripts/get_maintainer.pl  patches/tmp/0007-media-staging-media-intel-ipu3-reduce-length-of-line.patch
    Cc + cover Cc: Bingbu Cao <bingbu.cao@intel.com> (reviewer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> (commit_signer)
    Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (commit_signer)
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (commit_signer)
    Cc: Mitali Borkar <mitaliborkar810@gmail.com> (commit_signer)
    Cc: Rahul Gottipati <rahul.blr97@gmail.com> (cc)
    Cc: Sakari Ailus <sakari.ailus@linux.intel.com> (commit_signer)
    Cc + cover Cc: Tianshu Qiu <tian.shu.qiu@intel.com> (reviewer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0008-media-staging-media-intel-ipu3-remove-space-before-t.patch
./scripts/get_maintainer.pl  patches/tmp/0008-media-staging-media-intel-ipu3-remove-space-before-t.patch
    Cc + cover Cc: Bingbu Cao <bingbu.cao@intel.com> (reviewer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> (commit_signer)
    Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (commit_signer)
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (commit_signer)
    Cc: Mitali Borkar <mitaliborkar810@gmail.com> (commit_signer)
    Cc: Rahul Gottipati <rahul.blr97@gmail.com> (cc)
    Cc: Sakari Ailus <sakari.ailus@linux.intel.com> (commit_signer)
    Cc + cover Cc: Tianshu Qiu <tian.shu.qiu@intel.com> (reviewer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0009-media-staging-media-intel-ipu3-line-should-not-end-w.patch
./scripts/get_maintainer.pl  patches/tmp/0009-media-staging-media-intel-ipu3-line-should-not-end-w.patch
    Cc + cover Cc: Bingbu Cao <bingbu.cao@intel.com> (reviewer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> (commit_signer)
    Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (cc)
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (commit_signer)
    Cc: Mitali Borkar <mitaliborkar810@gmail.com> (commit_signer)
    Cc: Rahul Gottipati <rahul.blr97@gmail.com> (commit_signer)
    Cc: Sakari Ailus <sakari.ailus@linux.intel.com> (commit_signer)
    Cc + cover Cc: Tianshu Qiu <tian.shu.qiu@intel.com> (reviewer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0010-media-staging-media-zoran-add-spaces-around-operator.patch
./scripts/get_maintainer.pl  patches/tmp/0010-media-staging-media-zoran-add-spaces-around-operator.patch
    Cc + cover Cc: Corentin Labbe <clabbe@baylibre.com> (maintainer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc + cover Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (maintainer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
    Cc + cover Cc: mjpeg-users@lists.sourceforge.net (open list)
Checking patches/tmp/0011-media-staging-media-atomisp-Minor-code-style-changes.patch
./scripts/get_maintainer.pl  patches/tmp/0011-media-staging-media-atomisp-Minor-code-style-changes.patch
    Cc: Filip Kolev <fil.kolev@gmail.com> (commit_signer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> (commit_signer)
    Cc: Martiros Shakhzadyan <vrzh@vrzh.net> (commit_signer)
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (commit_signer)
    Cc + cover Cc: Sakari Ailus <sakari.ailus@linux.intel.com> (reviewer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0012-media-staging-media-omap4iss-Remove-unused-macro-fun.patch
./scripts/get_maintainer.pl  patches/tmp/0012-media-staging-media-omap4iss-Remove-unused-macro-fun.patch
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc + cover Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (maintainer)
    Cc + cover Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (maintainer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0013-media-staging-media-atomisp-pci-Correct-identation-i.patch
./scripts/get_maintainer.pl  patches/tmp/0013-media-staging-media-atomisp-pci-Correct-identation-i.patch
    Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (commit_signer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (commit_signer)
    Cc + cover Cc: Sakari Ailus <sakari.ailus@linux.intel.com> (reviewer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0014-media-staging-media-atomisp-pci-Correct-identation-i.patch
./scripts/get_maintainer.pl  patches/tmp/0014-media-staging-media-atomisp-pci-Correct-identation-i.patch
    Cc: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com> (commit_signer)
    Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (commit_signer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> (commit_signer)
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (commit_signer)
    Cc: Sakari Ailus <sakari.ailus@linux.intel.com> (commit_signer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0015-media-staging-media-atomisp-pci-Format-comments-acco.patch
./scripts/get_maintainer.pl  patches/tmp/0015-media-staging-media-atomisp-pci-Format-comments-acco.patch
    Cc: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com> (commit_signer)
    Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (commit_signer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> (commit_signer)
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (commit_signer)
    Cc: Sakari Ailus <sakari.ailus@linux.intel.com> (commit_signer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
Checking patches/tmp/0016-media-staging-media-atomisp-pci-Format-comments-acco.patch
./scripts/get_maintainer.pl  patches/tmp/0016-media-staging-media-atomisp-pci-Format-comments-acco.patch
    Cc: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com> (commit_signer)
    Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (commit_signer)
    Cc: Arnd Bergmann <arnd@arndb.de> (commit_signer)
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cc)
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> (commit_signer)
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (commit_signer)
    Cc + cover Cc: Sakari Ailus <sakari.ailus@linux.intel.com> (reviewer)
    Cc + cover Cc: devel@driverdev.osuosl.org (open list)
    Cc + cover Cc: linux-kernel@vger.kernel.org (open list)
    Cc + cover Cc: linux-media@vger.kernel.org (open list)
patches/tmp/0000-cover-letter.patch:
    Cc: Bingbu Cao <bingbu.cao@intel.com>
    Cc: Corentin Labbe <clabbe@baylibre.com>
    Cc: Ezequiel Garcia <ezequiel@collabora.com>
    Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
    Cc: Philipp Zabel <p.zabel@pengutronix.de>
    Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
    Cc: Tianshu Qiu <tian.shu.qiu@intel.com>
    Cc: devel@driverdev.osuosl.org
    Cc: linux-kernel@vger.kernel.org
    Cc: linux-media@vger.kernel.org
    Cc: linux-rockchip@lists.infradead.org
    Cc: mjpeg-users@lists.sourceforge.net
Number of Cc at cover: 13
</snip>

I guess I'll post it as a RFC patch c/c this thread.

Thanks,
Mauro