Re: Multi-patch series broken in b4 master

[Konstantin Ryabitsev <konstantin@linuxfoundation.org>]

On Fri, Jun 11, 2021 at 01:55:29PM +0200, Geert Uytterhoeven wrote:
> Hi Konstantin,
> 
> Commit c2e1aa9cbbf3d89a ("Save exploded pull requests as maildirs
> as well") broke patch series containing more than one patch, as the
> resulting .mbx file no longer has the needed separators between emails.

Oooh, I think we discovered a bug in Python that doesn't actually write the
proper "From " header when running as_string() as opposed to as_bytes().

    $ cat test.py
    #!/usr/bin/env python3
    import sys
    import email.message

    msg = email.message.EmailMessage()
    msg.set_payload('Hello World')
    msg['Subject'] = 'Hello'
    msg['From'] = 'Me <me@foo.bar>'
    print('as_string:')
    print(msg.as_string(unixfrom=True))
    print()
    print('as_bytes:')
    print(msg.as_bytes(unixfrom=True).decode())

    $ python3 test.py
    as_string:
    Subject: Hello
    From: Me <me@foo.bar>

    Hello World

    as_bytes:
    From nobody Fri Jun 11 08:34:11 2021
    Subject: Hello
    From: Me <me@foo.bar>

    Hello World

According to the docs, the output should be identical, but the "From " part is
only present in the second version, which is specifically not what the docs
say should happen:
https://docs.python.org/3/library/email.message.html#email.message.EmailMessage.as_string

I'll open a bug with Python and work around this in b4.

Thanks for the report -- I'll push out a 0.7.3 shortly.

-K