Re: [PATCH v7 0/2] Run TPM2_Shutdown on system shutdown

From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Josh Zimmerman <joshz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org>,
	Marcel Selhorst <tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org>,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org
Subject: Re: [PATCH v7 0/2] Run TPM2_Shutdown on system shutdown
Date: Thu, 29 Jun 2017 16:28:11 +0300	[thread overview]
Message-ID: <1498742891.30068.1.camel@linux.intel.com> (raw)
In-Reply-To: <20170625215324.17467-1-joshz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>

On Sun, 2017-06-25 at 14:53 -0700, Josh Zimmerman wrote:
> This patchset causes all devices in the tpm class to issue TPM2_Shutdown
> when the system is shutting down.
> 
> As a prerequisite, it adds a "shutdown" method to "struct class".
> 
> Since this bug can cause users to be locked out of their TPMs, I'd like
> this patch included in at least 4.4 and 4.9. 4.1 is nice-to-have but not
> essential.
> 
> gregkh Acked the proposal for stable in v3 of this patch.
> 
>  drivers/base/core.c          |  6 +++++-
>  drivers/char/tpm/tpm-chip.c  | 34 ++++++++++++++++++++++++++++++++++
>  drivers/char/tpm/tpm-sysfs.c |  3 +++
>  include/linux/device.h       |  2 ++
>  4 files changed, 44 insertions(+), 1 deletion(-

Josh,

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

I'll rebase my next after testing (and add also Tested-by).

I have one question as you are more familiar with the issue a hand.
What if you just cut the power from the device, does this affect
DA counter?

/Jarkko

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot