From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Josh Zimmerman <joshz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org
Subject: Re: [PATCH v6 1/2] tpm: Issue a TPM2_Shutdown for TPM2 devices.
Date: Wed, 21 Jun 2017 09:37:13 +0200 [thread overview]
Message-ID: <20170621073713.wqo5oizybxoxp7da@linux.intel.com> (raw)
In-Reply-To: <20170620150541.x5b7vkxyb3w55gjq-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
While you still have to work on this, could you name the function as
tpm_class_shutdown() to better claarify its purpose? Otherwise, things
start to look a bit confusing. Thanks.
/Jarkko
On Tue, Jun 20, 2017 at 05:05:41PM +0200, Jarkko Sakkinen wrote:
> No worries. Just fix them and I will include to my next pull request!
>
> /Jarkko
>
> On Mon, Jun 19, 2017 at 03:44:55PM -0700, Josh Zimmerman wrote:
> > Sorry about the mess. I'm a bit swamped today, but I'll work on
> > cleaning up the patch formatting & commit message and fix the
> > compilation problem later today or tomorrow. (It did build on my
> > checkout of the tpmdd branch... guess I didn't pull in some important
> > change.)
> > Josh
> >
> >
> > On Mon, Jun 19, 2017 at 3:38 PM, Jarkko Sakkinen
> > <jarkko.sakkinen@linux.intel.com> wrote:
> > > On Tue, Jun 20, 2017 at 12:21:22AM +0200, Jarkko Sakkinen wrote:
> > >> On Tue, Jun 20, 2017 at 12:12:20AM +0200, Jarkko Sakkinen wrote:
> > >> > On Mon, Jun 19, 2017 at 09:51:22AM -0600, Jason Gunthorpe wrote:
> > >> > > On Mon, Jun 19, 2017 at 01:26:47AM +0200, Jarkko Sakkinen wrote:
> > >> > >
> > >> > > > Feels weird that you have to call framework functions like that in the
> > >> > > > driver. You must have brilliant reason to do so and that should be very
> > >> > > > well documented in the code. This is terrible...
> > >> > >
> > >> > > This was all discussed on the list. It the way these callbacks work,
> > >> > > the higher levels in the callback stack call the lower levels, this
> > >> > > allows each level the place the next level's callback properly, eg do
> > >> > > things before/after as necessary.
> > >> > >
> > >> > > Jason
> > >> >
> > >> > I tried to look up for discussion from the patchwork. These had appeared
> > >> > in v6. I guess I have to backtrack the discussions from my maidir
> > >> > because I honestly don't understand why class shutdown would have to
> > >> > call bus callback explicitly. There's nothing in the commit message
> > >> > about this nor is there any comment in the code.
> > >> >
> > >> > This must be fairly recent development that I've missed?
> > >> >
> > >> > /Jarkko
> > >>
> > >> Found it:
> > >>
> > >> "Looking at this closer, now you definately have to change the TPM
> > >> patch to call through to the other shutdown methods. We can say
> > >> current TPM drivers have no driver->shutdown, but we cannot be sure
> > >> about the bus->shutdown, so may as well call both from tpm's
> > >> class->shutdown.
> > >>
> > >> I would say this should be done after the tpm2_shutdown completes as
> > >> lower level shutdowns could remove register access.
> > >>
> > >> Jason"
> > >>
> > >> And makes sense.
> > >>
> > >> This patch is a NAK for two reasons:
> > >>
> > >> 1. No comment explaining this.
> > >> 2. Patches are broken and they are in wrong order and cover letter is
> > >> missing
> > >>
> > >> /Jarkko
> > >
> > > I *tried* to apply them myself after sending this in order to be helpful
> > > but they have compilation errors:
> > >
> > > drivers/char/tpm/tpm-chip.c: In function ‘tpm_shutdown’:
> > > drivers/char/tpm/tpm-chip.c:162:23: error: ‘TPM_SU_CLEAR’ undeclared (first use in this function)
> > > tpm2_shutdown(chip, TPM_SU_CLEAR);
> > > ^~~~~~~~~~~~
> > > drivers/char/tpm/tpm-chip.c:162:23: note: each undeclared identifier is reported only once for each function it appears in
> > > drivers/char/tpm/tpm-chip.c: In function ‘tpm_chip_alloc’:
> > > drivers/char/tpm/tpm-chip.c:214:17: error: ‘chip->dev.class’ is a pointer; did you mean to use ‘->’?
> > > chip->dev.class.shutdown = tpm_shutdown;
> > >
> > > /Jarkko
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> tpmdd-devel mailing list
> tpmdd-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
tpmdd-devel mailing list
tpmdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
next prev parent reply other threads:[~2017-06-21 7:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 17:25 [PATCH v6 1/2] tpm: Issue a TPM2_Shutdown for TPM2 devices Josh Zimmerman via tpmdd-devel
[not found] ` <20170616172531.28464-1-joshz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-06-16 17:25 ` [PATCH v6 2/2] Add "shutdown" to "struct class" Josh Zimmerman via tpmdd-devel
2017-06-18 21:53 ` [PATCH v6 1/2] tpm: Issue a TPM2_Shutdown for TPM2 devices Jarkko Sakkinen
2017-06-18 23:21 ` Jarkko Sakkinen
[not found] ` <1497828091.2552.6.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-18 23:26 ` Jarkko Sakkinen
[not found] ` <1497828407.2552.8.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-19 15:51 ` Jason Gunthorpe
[not found] ` <20170619155122.GA10188-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-19 22:12 ` Jarkko Sakkinen
[not found] ` <20170619221220.kfk5dldducxvou5b-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-19 22:21 ` Jarkko Sakkinen
[not found] ` <20170619222122.55m5goanayw3gkeo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-19 22:38 ` Jarkko Sakkinen
[not found] ` <20170619223840.a66extf3r5ylmpnb-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-19 22:44 ` Josh Zimmerman via tpmdd-devel
[not found] ` <CAHSjozDy0dsGPkyXzVsDabjtbM4-QkzoE2fH1gDONXETyA19RA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-20 15:05 ` Jarkko Sakkinen
[not found] ` <20170620150541.x5b7vkxyb3w55gjq-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-21 7:37 ` Jarkko Sakkinen [this message]
2017-06-20 8:44 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2017-06-02 21:55 Josh Zimmerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621073713.wqo5oizybxoxp7da@linux.intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org \
--cc=joshz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).